Skip to content

Conversation

@MarshalX
Copy link
Contributor

@MarshalX MarshalX commented Jan 30, 2024

it fixes a lot of problems with detection annotation including SCA lock files of all other package systems installed as 3d party plugins;

So, in the end, we have a shared annotator across the whole app

@MarshalX MarshalX changed the title CM-31904 - Add cycode annotator for all registered languages CM-31904 - Add cycode annotator for all registered languages; fix scan results sharing between projects Jan 30, 2024
@MarshalX
Copy link
Contributor Author

MarshalX commented Jan 30, 2024

do not merge. now we should track that the psi file was already annotated with the same scan results. because one file could be associated with many languages. it will call the annotator many times which causes duplicates

fixed

@MarshalX MarshalX changed the title CM-31904 - Add cycode annotator for all registered languages; fix scan results sharing between projects CM-31904 - Add cycode annotator for all registered languages Jan 31, 2024
@MarshalX
Copy link
Contributor Author

MarshalX commented Jan 31, 2024

i moved scan results fix to another PR #42

@MarshalX MarshalX changed the title CM-31904 - Add cycode annotator for all registered languages CM-31904 - Fix external annotator for registered languages Jan 31, 2024
@MarshalX MarshalX requested a review from MaorDavidzon January 31, 2024 17:09
@MarshalX MarshalX merged commit 41ea9b7 into main Feb 1, 2024
@MarshalX MarshalX deleted the CM-31904-add-cycode-annotator-for-all-registered-languages branch February 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants