Filter and sort releases list, then show the latest ones for 7.x and 8.x #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
commented
May 18, 2020
| load balancing at start-up, and it scales arbitrarily well with the | ||
| number of host VMs. Running workflows can self-migrate to another | ||
| host at maintenance time. </p> | ||
| host at maintenance time. </p> |
There was a problem hiding this comment.
Changes above were added automatically by the IDE, but I thought it was OK. Removing extra spaces.
| "cylc8", | ||
| latestCylc8.name, | ||
| `${TAGS_URL}${latestCylc8.tag_name}`, | ||
| getReleaseDate(latestCylc8)) |
There was a problem hiding this comment.
Iterating arrays is cheap, so we just iterate twice, filtering by the release name, sorting by date asc, and getting the last item with .pop(), which may return undefined.
If not undefined, then we use the old code to populate the HTML elements in the UI.
hjoliver
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally.