This repository was archived by the owner on Jan 31, 2023. It is now read-only.
using prettier-eslint #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahmutov
requested review from
avanslaars,
brian-mann,
chrisbreiding and
jennifer-shehane
avanslaars
approved these changes
Nov 21, 2017
chrisbreiding
previously requested changes
Nov 22, 2017
index.js
Outdated
| // it gets the latest bundle | ||
| const bundlePromise = bundles[filePath] = bundle() | ||
| .finally(() => { | ||
| const bundlePromise = (bundles[filePath] = bundle().finally(() => { |
Collaborator
There was a problem hiding this comment.
I'd rather see this without the bizarre parentheses. I guess that means it needs to be 2 lines:
const bundlePromise = bundle.finally(() => {
// ...
bundles[filePath] = bundlePromise
updated code to avoid parens
chrisbreiding
approved these changes
Nov 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to respect our eslint rules!