-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Provide proper --args for any place utilizing rawRender
#2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….js`- `note.js` now renders with rawRender
`Note.js` update to reflect that rawRender returns a promise and not a string
--args for any place utilizing rawRender--args for any place utilizing rawRender
|
Closing for now to explore upgrading |
|
Reopening this PR: the alternative approach of upgrading seems like a decent size undertaking. |
--args for any place utilizing rawRender--args for any place utilizing rawRender
--args for any place utilizing rawRender--args for any place utilizing rawRender
|
Note: this will not fix cases where more than a fenced code block in the |
|
This does fix cases where the |
|
Actually, I'm starting to think that this issue was always isolated to text within code blocks within urls where the beginning text was |
This feels like a hack, but it resolves the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this partially addresses things. Thanks!
|
Looks like this might have broken the notes tag rendering. |

changelog.jsnote.jsnow renders with rawRenderBlocks of
<code>--arg</code>are converted to<code>-arg</code>. This does not occur when code is within a code block; i.e.The desire is to maintain the double
--in output. A fix was put in fornote.jsin PR #935. This fix was moved torawRender.jsso that any renderer using this will pick up this fix; includingchangelog.js. Also, updatenote.jsto leveragerawRender.Close #2196