Update viewport arguments with changes to width and height bounds #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think it makes more sense to close this now actually and reopen or create a new once the main PR is okayed. |
|
We use Zenhub and add dependencies that block the PR merge until the main project's PR is accepted. So this is a perfectly normal workflow to leave this open. Also, could you make sure to sign our CLA. :) |
|
@jennifer-shehane: Oh, I see. Thanks for reopening then. :) I updated the recent commit to match the "implementation" PR (cypress-io/cypress#1448). |
brian-mann
pushed a commit
that referenced
this pull request
May 29, 2018
* update Dashboard service screenshots / content - update some of the screenshots to reflect the new tabs - change some of the wording about where you can access screenshots and videos * Update description and examples for '--spec' arg in command log * Began writing changelog for 3.0.0 * update roadmap to remove 'running multiple specs' - added some other issues to future roadmap * Update docs to reflect new example seeded files * Add more merged PRs to the changelog * added more 3.0 fixes to changelog - updated ‘close’ event specs to new changes. * add newest commits to changelog * Add more merged PRs to changelog * package.lock update * Added a couple merged prs to changelog * update package.lock * Add doc for cy.task() (#445) * add doc for cy.task() * fix hexo version * update task doc to latest api * add task event references * add references for cy.task recipe * remove 'comments: false' from each files - it does nothing. close #141 * Added Cypress binary feature to changelog - removed from roadmap * Begin editing cy.task() doc * Normalize use of Node across docs to be capitalized and not in code brackets * Edit cy.task * Update viewport arguments with changes to width and height bounds (#456) * add screenshot content to changelog - update command line to show accepting multiple specs in —spec flag. * Add screenshot configuration doc (#480) * package-lock changes * fix invalid css * add doc for Cypress.Screenshot api * update screenshot doc with latest capture values * update screenshot docs * update screenshot docs with latest api * add screenshot content to changelog - update command line to show accepting multiple specs in —spec flag. * store npm-debug logs in artifacts * npm logs * fix package-lock.json weirdness - needed to delete node_modules locally. * Fix bug with changelog not displaying completely * Clean up screenshot doc for release * Edit screenshot api file * Update screenshot doc to be more specific after clarification. * Added an example of seeding a db to cy.task * added newest chrome flag to changelog * package-lock changes * fix time out grammar * update screenshot docs to latest api * fullpage -> fullPage * CLI Caching (#596) * update installing page * update docs with new env vars * woops - forgot to save package-lock * Added newly fixed issues to changelog * Clean up some of new docs * package-lock * Add 2 new issues to changelog * Update uses of 'headless' to ‘during cypress run’ - Update uses of ‘GUI’ to ‘Test Runner’ or ‘interactive’ - some h3 header conversions * Update answer in FAQ on 'how to run group of specs' to match new spec arg * Update launching browsers to say we now disable device discovery notifications * Rename config trashAssetsBeforeHeadlessRuns to trashAssetsBeforeRuns * Fixes to inaccurate docs - remove mention of cy.screenshot yielding ‘null’ - add cy.screenshot as example of dual command - add more h3 conversions - add cy.task to more references in other docs * Update dashboard content/screenshots - put screenshots of new uis * update changelog to specify that video filenames are only changed locally * SelectorPlayground -> Screenshot in screenshot api doc * document screenshot callbacks * add missing 'is' * Add missing 'is' * clean up some headers/content for screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update are in reference to cypress-io/cypress#1444.
If cypress-io/cypress#1448 is excepted, then this PR updates the corresponding docs. Lowers the current minimum lower bound on
cy.viewportfrom200to20pixels.