-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update network request guide to include info about disabling logging #5124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d3e576c
update command log guide to inform users they can disable logging
mjhenkes 2fcf379
add missing curly brace
mjhenkes c020484
Update docs/guides/guides/network-requests.mdx
mjhenkes 81aab1c
add link to example of turning off all intercept logs
mjhenkes 1b7d1ad
Merge branch 'main' into matth/command-log-update
mjhenkes eea08f6
lint fixes
mjhenkes 95c2510
Update docs/guides/guides/network-requests.mdx
mjhenkes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the example that disables all xhr/fetch logs?
https://docs.cypress.io/api/commands/intercept#Disabling-logs-for-a-request
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specifically used the example from farther down in the guide to match: https://github.com/cypress-io/cypress-documentation/pull/5124/files#diff-bb8ce895b7660f9f324902a3e98c85d05f942fdd16997394dd5fc0dc46abb095L554
but could change to disable all if people want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also link out to the example that shows how to disable all if we didn't want to update here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in c020484