Consolidate Linux prerequisites #5751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Contributor
Author
|
Preview |
jennifer-shehane
approved these changes
Mar 14, 2024
Member
jennifer-shehane
left a comment
jennifer-shehane
left a comment
There was a problem hiding this comment.
Looks great. Should be less confusing.
Contributor
Author
I hope it will be less confusing, yes! I think the references to Docker could be improved, but I didn't want to try to do too much in one PR otherwise it becomes difficult to review. I'll make suggestions to address this area sometime soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The lists of required Linux dependencies are kept in two different locations, with differing contents:
Continuous Integration > Advanced setup > Dependencies
Getting Started > Installing Cypress > System requirements > Linux Prerequisites
Change
Continuous Integration > Advanced setup > Dependencies is changed to point to the list on
Getting Started > Installing Cypress > System requirements > Linux Prerequisites.
Various texts and links are also updated. Default Ubuntu installations and GitHub Ubuntu runners already include the necessary Linux packages, so the text is changed to assume that it is more likely than not that the dependencies don't need to be additionally installed, without assuming that they are always already installed.
Note
Getting Started > Installing Cypress > System requirements > Linux Prerequisites (see Differing Dependency lists #5749 (comment)). The URL https://on.cypress.io/required-dependencies is displayed by Cypress at runtime if a missing dependency is detected.