Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct broken links in README.md #665

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Dec 12, 2022

This PR resolves issue #663 "Broken links in README"

It corrects bad links in the README.md document which caused 400 (Bad Request) and 404 (Not Found) errors.

In addition it replaces links in README.md which were previously pointing to documents on https://help.github.com/. Links now use https://docs.github.com/ instead.

The use of the new links takes account of the help restructuring by bundling some links together for a better user experience and to better isolate from possible future GitHub help document restructuring.


GitHub has been restructured and

Verification

Execute npm run check:markdown and ensure that there are no Status 400 (Bad Request) or 404 (Not Found) errors.

NOTE
This PR does not solve 403 Forbidden errors. This is the subject of issue #664.

@jaffrepaul
Copy link
Contributor

Good stuff! While this fixed outdated Cypress links, I'm seeing a handful of dead Github links when running npm run check:markdown in the repo root. Rather, they do actually work if you navigate manually. Maybe the "help" subdomain is doing some fancy server redirects 🤷‍♂️

Would you mind updating these to the docs.github.com/en/xxx while you're in here? 💪

Screen Shot 2022-12-12 at 5 11 08 PM

Content from help.github.com has been moved to docs.github.com and restructured. The README links are updating accordingly.
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Dec 13, 2022

Good stuff! While this fixed outdated Cypress links, I'm seeing a handful of dead Github links when running npm run check:markdown in the repo root. Rather, they do actually work if you navigate manually. Maybe the "help" subdomain is doing some fancy server redirects 🤷‍♂️

The links which work but produce errors are throwing 403 forbidden errors. Since there were multiple things going wrong I split up the 403 problem into a different issue (#664). Sorry I didn't explain that here better!

Would you mind updating these to the docs.github.com/en/xxx while you're in here? 💪

I have done as you asked and converted the links to docs.github.com/en/xxx. They still produce a 403 forbidden error though, but at least they are all now using the current domain and not relying on redirects. I also added this information to the original posting.

403 dead links

I accelerated submitting the solution to the 403 error and you now have another PR (#667) to look at! Taken together they should solve the link issues. It would be best to merge the broken links PR (this one) before the 403 PR (#667) in order to avoid main.yml failing if it correctly finds failing links.

@jaffrepaul jaffrepaul merged commit 57031a3 into cypress-io:master Dec 13, 2022
@MikeMcC399 MikeMcC399 deleted the fix/bad-readme-links branch December 13, 2022 17:43
@github-actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kodiakhq bot referenced this pull request in weareinreach/InReach Dec 20, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout) | action | digest | `7dd9e2a` -> `755da8c` |
| [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `0ec8cd8` -> `2440d35` |
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.0` -> `v5.0.2` |
| [github/codeql-action](https://togithub.com/github/codeql-action) | action | digest | `a669cc5` -> `959cbb7` |
| [tinkurlab/monorepo-pr-labeler-action](https://togithub.com/tinkurlab/monorepo-pr-labeler-action) | action | patch | `4.1.2` -> `4.1.3` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.2`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.2)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.1...v5.0.2)

Numerous housekeeping updates to bring this action back up to speed.

\*In combination with v5.0.1, which triggered without a new dist build.

👏 Special thanks to [@&#8203;MikeMcC399](https://togithub.com/MikeMcC399) for all the diligent work! 👏

**Fix Failed Tests**

-   [https://github.com/cypress-io/github-action/pull/643](https://togithub.com/cypress-io/github-action/pull/643)
-   [https://github.com/cypress-io/github-action/pull/658](https://togithub.com/cypress-io/github-action/pull/658)
-   [https://github.com/cypress-io/github-action/pull/660](https://togithub.com/cypress-io/github-action/pull/660)

**Update Dependencies**

-   [https://github.com/cypress-io/github-action/pull/644](https://togithub.com/cypress-io/github-action/pull/644)
-   [https://github.com/cypress-io/github-action/pull/650](https://togithub.com/cypress-io/github-action/pull/650)

**Resolve Warnings**

-   [https://github.com/cypress-io/github-action/pull/651](https://togithub.com/cypress-io/github-action/pull/651)
-   [https://github.com/cypress-io/github-action/pull/666](https://togithub.com/cypress-io/github-action/pull/666)
-   [https://github.com/cypress-io/github-action/pull/670](https://togithub.com/cypress-io/github-action/pull/670)
-   [https://github.com/cypress-io/github-action/pull/675](https://togithub.com/cypress-io/github-action/pull/675)

**Docs/Example Updates**

-   [https://github.com/cypress-io/github-action/pull/665](https://togithub.com/cypress-io/github-action/pull/665)
-   [https://github.com/cypress-io/github-action/pull/668](https://togithub.com/cypress-io/github-action/pull/668)

**Tooling Updates:**

-   [https://github.com/cypress-io/github-action/pull/667](https://togithub.com/cypress-io/github-action/pull/667)
-   [https://github.com/cypress-io/github-action/pull/677](https://togithub.com/cypress-io/github-action/pull/677)

### [`v5.0.1`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.1)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.0...v5.0.1)

##### Bug Fixes

-   correct .gitignore for videos and screenshots ([89e59e5](https://togithub.com/cypress-io/github-action/commit/89e59e5cfc7760513fe9e9ce4c690345d94eb27a))

</details>

<details>
<summary>tinkurlab/monorepo-pr-labeler-action</summary>

### [`v4.1.3`](https://togithub.com/TinkurLab/monorepo-pr-labeler-action/releases/tag/4.1.3): Monorepo PR Labeler v4.1.3

[Compare Source](https://togithub.com/tinkurlab/monorepo-pr-labeler-action/compare/4.1.2...4.1.3)

Changes include:

Bug fix to ignore directories starting with a dot `.` but not directories that contain a dot `.`. According to the docs, this action should ignore mono repos that begin with a dot but it currently ignores also mono repo with a dot even if it is not the first character. Thanks to [@&#8203;MoLow](https://togithub.com/MoLow) for the fix!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #107
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants