Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#82] Add email and password pair analyzer #87

Merged
merged 76 commits into from
Oct 7, 2019

Conversation

bajubullet
Copy link
Contributor

My first PR, please let me know if I am missing something.

@coveralls
Copy link

coveralls commented Oct 4, 2019

Pull Request Test Coverage Report for Build 170

  • 383 of 487 (78.64%) changed or added relevant lines in 30 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.6%) to 64.571%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/analyzers/tests/battlenetkeyanalyzer_test.py 26 27 96.3%
pastepwn/analyzers/tests/emailpasswordpairanalyzer_test.py 38 39 97.44%
pastepwn/analyzers/tests/epickeyanalyzer_test.py 30 31 96.77%
pastepwn/analyzers/tests/microsoftkeyanalyzer_test.py 32 33 96.97%
pastepwn/analyzers/tests/originkeyanalyzer_test.py 30 31 96.77%
pastepwn/analyzers/tests/phonenumberanalyzer_test.py 36 37 97.3%
pastepwn/analyzers/tests/shahashanalyzer_test.py 36 37 97.3%
pastepwn/analyzers/tests/steamkeyanalyzer_test.py 32 33 96.97%
pastepwn/analyzers/tests/uplaykeyanalyzer_test.py 24 25 96.0%
pastepwn/analyzers/urlanalyzer.py 0 1 0.0%
Totals Coverage Status
Change from base Build 96: 5.6%
Covered Lines: 2260
Relevant Lines: 3500

💛 - Coveralls

@d-Rickyy-b
Copy link
Owner

Great work. Will have a closer look tonight! Thank you.

Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some more characters to the regex? Thank you :)

# -*- coding: utf-8 -*-
from .regexanalyzer import RegexAnalyzer

_EMAIL_PASSWORD_REGEX = r'[\w\.\+_-]+@[\w\._-]+\.[a-zA-Z]*\:[\w\.\+\!\$\#\^&\*\(\)\{\}\[\]\_\-\@\%\=]+$'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice regex, but there are some characters which are often used in passwords such as '§´/\?<>;:|",~ and the backtick character. Maybe you could add them to the regex as well? How should we deal with spaces? I would say we ignore spaces for now.

An example of a possible regex: \§\\\/\'\`\´\?\<\>\;\"\:\|\,\~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ignoring the spaces for now and updating the password regex

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

pastepwn/analyzers/emailpasswordpairanalyzer.py Outdated Show resolved Hide resolved
d-Rickyy-b and others added 4 commits October 6, 2019 03:46
I checked this regex against a pastebin with origin and steam keys in it.  It matches on Origin keys.
Zeroji and others added 27 commits October 6, 2019 16:28
Adds easier templating and fixes 'None' values
Implement Battle.Net Key Analyzer
Microsoft License key analyzer.
Microsoft key analyzer tests
Update init.
Uses websockets to open a connection to Discord's Gateway,
then sends the proper identification payload so that further requests
are authorized. This code runs only if sending
messages fails with code 40001.
That way it only needs to be imported when actually using the bot functionality
I guess this happens for multi threaded programs. No idea how this performs in the long run. Longest test has been 2 minutes and it worked for that time at least.
…cated

Add Discord action (webhook or bot token)
Created basic Epic Key analyzer with unit test
fixes d-Rickyy-b#97
Repository owner deleted a comment Oct 7, 2019
@d-Rickyy-b d-Rickyy-b merged commit f0af9cb into d-Rickyy-b:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.