Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Conversation

@GeorgiSTodorov
Copy link
Contributor

Prevent the find function from returning undefined in order to fix a dcos-ui bug.

Closes https://jira.mesosphere.com/browse/DCOS-48704

Testing

  1. In dcos-ui in dcos-ui/node_modules/reactjs-components/lib/Util/Util.js in the find function change return result; to return result || {}; on line 472.
  2. Run npm start and open the localhost.
  3. Open Organization > Users.
  4. Create a new user and open it.
  5. Open the permissions builder modal.
  6. Click around and verify that the modal doesn't crash.
    Here are some cases that broke it before:
  • From Services -> Marathon -> Operator > Leadership to Services -> Marathon -> Operator > Events.
  • From Admin Router > Services > Metronome (Jobs) to Secrets Store.
  • From Mesos > Master > Framework > Role to Mesos > Master > Framework > Service Account and vice versa.
  • From Mesos > Master > Quota to Mesos > Master > Executor.

Trade-offs

None.

Dependencies

After merging this, we will also have to update the reactjs-components version in dcos-ui.

Screenshots

Before

Peek 2019-06-19 11-53
Peek 2019-06-19 11-52

After

Peek 2019-06-19 11-56
Peek 2019-06-19 11-55

Prevent the find function from returning undefined in order to fix a dcos-ui bug.

Closes DCOS-48704
@TattdCodeMonkey TattdCodeMonkey merged commit 1adfbe5 into master Jun 19, 2019
@TattdCodeMonkey TattdCodeMonkey deleted the gt/fix/DCOS-48704-permissions-builder-exception branch June 19, 2019 18:54
@mesosphere-frontend-ci
Copy link
Contributor

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants