This repository was archived by the owner on Oct 23, 2024. It is now read-only.
DCOS-48704: Permissions builder exception #545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the find function from returning undefined in order to fix a dcos-ui bug.
Closes https://jira.mesosphere.com/browse/DCOS-48704
Testing
dcos-ui/node_modules/reactjs-components/lib/Util/Util.jsin the find function changereturn result;toreturn result || {};on line 472.npm startand open the localhost.Here are some cases that broke it before:
Services -> Marathon -> Operator > LeadershiptoServices -> Marathon -> Operator > Events.Admin Router > Services > Metronome (Jobs)toSecrets Store.Mesos > Master > Framework > RoletoMesos > Master > Framework > Service Accountand vice versa.Mesos > Master > QuotatoMesos > Master > Executor.Trade-offs
None.
Dependencies
After merging this, we will also have to update the reactjs-components version in
dcos-ui.Screenshots
Before
After