Skip to content

Conversation

Fil
Copy link
Member

@Fil Fil commented May 21, 2019

fixes #109

It's a lot of code. Using v = valueof ? valueof(value) : value would be maybe a weeeny bit slower, but take less lines?

@Fil
Copy link
Member Author

Fil commented May 21, 2019

It would simplify some examples in https://observablehq.com/@d3/d3-least and d3.path

@mbostock
Copy link
Member

Superseded by #111. (You have write access to this repo, don’t you?)

@mbostock mbostock closed this May 21, 2019
@Fil
Copy link
Member Author

Fil commented May 21, 2019

You have write access to this repo, don’t you?

nope

@Fil Fil deleted the least-accessor branch May 21, 2019 17:49
@mbostock
Copy link
Member

Okay, I’ve created a team with write access to all D3 repos and added you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

d3.least[Index] should promote single-argument accessors to comparators.

2 participants