fix: return file with extension when url is extension-less

Author: jimlambie

README.md

@@ -1,7 +1,7 @@
 <img src="http://52.209.207.148/assets/products/dadi-cdn-full.png" alt="DADI CDN" height="65"/>
 
 [![npm (scoped)](https://img.shields.io/npm/v/@dadi/cdn.svg?maxAge=10800&style=flat-square)](https://www.npmjs.com/package/@dadi/cdn)
-[![coverage](https://img.shields.io/badge/coverage-68%25-yellow.svg?style=flat-square)](https://github.com/dadi/cdn)
+[![coverage](https://img.shields.io/badge/coverage-69%25-yellow.svg?style=flat-square)](https://github.com/dadi/cdn)
 [![Build Status](https://travis-ci.org/dadi/cdn.svg?branch=master)](https://travis-ci.org/dadi/cdn)
 [![JavaScript Style Guide](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat-square)](http://standardjs.com/)
 

dadi/lib/handlers/image.js

@@ -863,8 +863,16 @@ ImageHandler.prototype.contentType = function () {
   }
 }
 
+/**
+ * Returns the filename including extension of the requested image
+ * @returns {string} the filename of the image
+ */
 ImageHandler.prototype.getFilename = function () {
-  return this.fileName
+  if (path.extname(this.fileName) === '') {
+    return this.fileName + '.' + this.fileExt
+  } else {
+    return this.fileName
+  }
 }
 
 ImageHandler.prototype.getLastModified = function () {

test/unit/imagehandler.js

@@ -265,4 +265,30 @@ describe('ImageHandler', function (done) {
       done()
     })
   })
+
+  it('should return filename with jpg extension when a URL has no extension', function (done) {
+    var newTestConfig = JSON.parse(testConfigString)
+    newTestConfig.caching.directory.enabled = false
+    newTestConfig.caching.redis.enabled = false
+    cache.reset()
+    newTestConfig.images.directory.enabled = false
+    newTestConfig.images.s3.enabled = false
+    newTestConfig.images.remote.enabled = true
+    fs.writeFileSync(config.configPath(), JSON.stringify(newTestConfig, null, 2))
+
+    config.loadFile(config.configPath())
+
+    var req = {
+      headers: {},
+      url: '/test'
+    }
+
+    // set some expected values
+    var expected = 'test.jpg'
+
+    var im = new imageHandler('jpg', req)
+    im.getFilename().should.eql(expected)
+
+    done()
+  })
 })