forceMapping does not work on a multinode cluster

[iskytek]

spring config：

  <bean id="esNode"
        class="fr.pilato.spring.elasticsearch.ElasticsearchNodeFactoryBean">
    </bean>

    <bean id="esClient"
        class="fr.pilato.spring.elasticsearch.ElasticsearchClientFactoryBean" >
        <property name="mappings">
            <list>
                <value>twitter/tweet</value>
                <value>rss/feed</value>
                <value>rss/config</value>
            </list>
        </property>
        <property name="aliases">
            <list>
                <value>alltheworld:twitter</value>
                <value>alltheworld:rss</value>
            </list>
        </property>
        <property name="forceMapping" value="true" />
    </bean>

ElasticsearchAbstractClientFactoryBean method：

private void pushMapping(String index, String type, boolean force, boolean merge) throws Exception {
        if (logger.isTraceEnabled()) logger.trace("pushMapping("+index+","+type+","+force+")");

        checkClient();

        // If type already exists and if we are in force mode, we delete the type and its mapping
        if (force && isMappingExist(index, type)) {
            if (logger.isDebugEnabled()) logger.debug("Force remove old type and mapping ["+index+"]/["+type+"]");
            // Remove mapping and type in ElasticSearch !
            client.admin().indices()
                .prepareDeleteMapping(index)
                .setType(type)
                .execute().actionGet();

             Thread.sleep(500); // for now, we don't have ack logic, so just wait

        }

        // If type does not exist, we create it
        boolean mappingExist = isMappingExist(index, type);           
              // If  not sleep , here is always true 

        if (merge || !mappingExist) {
            if (logger.isDebugEnabled()) {
                if (mappingExist) {
                    logger.debug("Updating mapping ["+index+"]/["+type+"].");
                } else {
                    logger.debug("Mapping ["+index+"]/["+type+"] doesn't exist. Creating it.");
                }
            }
            // Read the mapping json file if exists and use it
            String source = readMapping(index, type);
            if (source != null) {
                if (logger.isTraceEnabled()) logger.trace("Mapping for ["+index+"]/["+type+"]="+source);
                // Create type and mapping
                PutMappingResponse response = client.admin().indices()
                    .preparePutMapping(index)
                    .setType(type)
                    .setSource(source)
                    .execute().actionGet();         
                if (!response.acknowledged()) {
                    throw new Exception("Could not define mapping for type ["+index+"]/["+type+"].");
                } else {
                    if (logger.isDebugEnabled()) {
                        if (mappingExist) {
                            logger.debug("Mapping definition for ["+index+"]/["+type+"] succesfully merged.");
                        } else {
                            logger.debug("Mapping definition for ["+index+"]/["+type+"] succesfully created.");
                        }
                    }
                }
            } else {
                if (logger.isDebugEnabled()) logger.debug("No mapping definition for ["+index+"]/["+type+"]. Ignoring.");
            }
        } else {
            if (logger.isDebugEnabled()) logger.debug("Mapping ["+index+"]/["+type+"] already exists and mergeMapping is not set.");
        }
        if (logger.isTraceEnabled()) logger.trace("/pushMapping("+index+","+type+","+force+")");
    }

[dadoonet]

Can you describe exactly what is the issue ?
Do you have something weird in logs ?
Is your client not initialized ?

Thanks for providing more details information about your concern.

[dadoonet]

Ok. I understood your issue.

[dadoonet]

Hmmm. Looks strange.
I can't reproduce it.

Here is what I did :

• Start an ES Node (bin/elasticsearch -f)
• Create a unit test using a TransportClient connected to the node
• Log the value of mappingExist

I started once to create rss and twitter index and types.

Then I restart again the test and mappingExist is always false.

Can you send your full testcase ?

Here is my spring xml file:

    <bean id="esClient"
        class="fr.pilato.spring.elasticsearch.ElasticsearchTransportClientFactoryBean" >
        <property name="classpathRoot" value="es13" />
        <property name="esNodes">
            <list>
                <value>localhost:9300</value>
            </list>
        </property>
        <property name="forceMapping" value="true" />
    </bean>

[iskytek]

Two consecutive will see the effect

[iskytek]

if  delete      Thread.sleep(500); // for now, we don't have ack logic, so just wait

then  you look look 

[dadoonet]

Issue raised in elasticsearch : elastic/elasticsearch#2054

[dadoonet]

@iskytek I just pushed the update with the latest ES release. Could you check it out, build it and give me a feedback ?
As I can't reproduce it, you are the only one that can confirm that everyhting is fine now.

Thanks