Allow Namespace defined node to be used with embedded settings

[ittaiz]

currently when using <elasticsearch:node /> you can only set the settingsFile but you can not specify a reference to an embedded properties instance which correlates to the settings property on the factory.
Basically I'm trying to assign "client=true" property to the node and I'd rather not have a whole file only for this configuration which does not change for me.
This is not a big deal but I think it's a better solution and it seems like it'snot a big change to add support for this in the bead builder.

[dadoonet]

Hi @ittaiz

Sorry for the long long long delay!

If I understand your concern, you want to be able to use a ref to properties instead of a file:

<elasticsearch:node id="esNode" settingsFileRef="esProperties" />

or

<bean id="esNode"
    class="fr.pilato.spring.elasticsearch.ElasticsearchNodeFactoryBean">
    <property name="settingsFile" ref="esProperties" />
</bean>

Do you have an example of how you will define your esProperties bean ?

Thanks
David;

[gregorko]

This could be a useful example

<util:map id="esProperties">
    <entry key="cluster.name" value="junit.cluster.transport"/>
</util:map>

What I specially like about this is that if you use a global server wide configuration file you might not like to have an additionally property file or you might like to combine a path by using keys from the global file. This could be done by using the PropertyPlaceholderConfigurer for something like this:

<util:map id="esProperties">
    <entry key="path.data" value="${global.dataDir}/elasticsearch"/>
</util:map>

This might even make sense to use in combination with a es property file:

<util:map id="esOverrideProperties">
    <entry key="path.data" value="${global.dataDir}/elasticsearch"/>
</util:map>

<elasticsearch:node id="esNode" settingsFile="/my/settings/file">
  <property name="settings" ref="esOverrideProperties">
</elasticsearch:node>

Please also think about using Springs Resource interface for file access. This would not only give you access to property files in the classpath but also any other location. This might be specially useful for a shared property file on a network.
http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/resources.html

[ittaiz]

Sorry for the late response.
I think gregorko nailed the usage I was aiming at.

On Tue, Oct 30, 2012 at 8:51 PM, gregorko notifications@github.com wrote:

This could be a usefull example

<util:map id="esProperties">
/util:map

What I specially like about this is that if you use a global server wide
configuration file you might not like to have an additionally property file
or you might like to combine a path by using keys from the global file.
This could be done by using the PropertyPlaceholderConfigurer for something
like this:

<util:map id="esProperties">
/util:map

This might even make sense to use in combination with a es property file:

<util:map id="esOverrideProperties">
/util:map
<elasticsearch:node id="esNode" settingsFile="/my/settings/file">
/elasticsearch:node

Please also think about using Springs Resource interface for file access.
This would not only give you access to property files in the classpath but
also any other location. This might be specially useful for a shared
property file on a network.

http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/resources.html

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-9918306.

[dadoonet]

That really makes sense. I will work on it. Thanks for the clarification.

[dadoonet]

@ittaiz @gregorko I finally found some spare time to work on it. I think it works now as expected.
Could you please have a look at it?
Branch is issue15: https://github.com/dadoonet/spring-elasticsearch/tree/issue15
Not yet merged in master.
Thanks for your feedback.

[gregorko]

Without having it used yet, it looks very good now and perfectly fits to my use case.
Thanks,
Gregor

[dadoonet]

Thanks for your feedback. I will merge it in master.

[rusnyder]

Hi @dadoonet

I came here looking to suggest this feature, and found you were already on it! I've pulled this branch down and my application is running swell with the new updates. Is there any timeframe on when these features might be made available in a Release or in a Milestone Release?

Thanks much!
Russell

[ittaiz]

Hi David,
Unfortunately I'm not using ES anymore (new job, no ES needs here) but I've looked at the commit and it looks what I needed.

Thanks

On Wed, May 15, 2013 at 12:59 PM, David Pilato notifications@github.com
wrote:

Thanks for your feedback. I will merge it in master.

Reply to this email directly or view it on GitHub:
#15 (comment)