fix: Recompute Content-Digest header value when signing content-digest component#116
Merged
Merged
Conversation
…nt-digest configured as component
Content-Digest header value when signing content-digest component
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 94.53% 94.52% -0.01%
==========================================
Files 18 18
Lines 1317 1315 -2
==========================================
- Hits 1245 1243 -2
Misses 37 37
Partials 35 35 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the signing behavior for the
content-digestcomponent.When
content-digestis configured as one of the signature components, the signer now always recomputes theContent-Digestheader from the current message body and replaces any existing value.Previously, an existing
Content-Digestheader was preserved. If that header was stale or incorrect, signing could produce a message that fails verification because the signed digest no longer matches the body.