🐞 [Rust SDK] Rust crate not compiling on Windows!

[MikeTeddyOmondi]

What is the issue?

I don't know if the Rust SDK was meant to be cross compatible (Unix & Windows) but it would be useful to allow the SDK be able to compile in Windows by separating the following configuration below referenced for Unix and Windows.

The issue is that the dagger-sdk crate is attempting to use Unix-specific functionality (os::unix::prelude::PermissionsExt and set_mode on Permissions) on a Windows platform. This won't work because the unix module within os is conditionally compiled out on Windows.

Here's a breakdown and how to address it:

• **Error E0433: could not find \unix` in `os`** This means the code is trying to access the unixmodule within theosmodule, but that module doesn't exist when compiling for Windows. Thecfgattributes in the standard library source code snippets you included confirm that theunix` module is excluded when the target OS is not a Unix-like system.
• **Error E0599: no method named \set_mode` found for struct `Permissions`** This is a consequence of the first error. The set_modemethod is provided by thePermissionsExt` trait, which is only available when compiling for Unix-like systems.

Dagger version

dagger v0.18.3

Steps to reproduce

The dagger-sdk crate needs to be modified to handle Windows properly. It should avoid using Unix-specific code when compiling for Windows. This likely involves using conditional compilation using cfg attributes to provide alternative implementations for file permission setting on Windows.

Here's the likely area in dagger-sdk-0.18.3\src\core\downloader.rs that needs changes:

use std::fs;
use std::os::unix::prelude::PermissionsExt; // Problematic line!

// ...

#[cfg(not(windows))]
fn set_executable_permission(path: &Path) -> Result<()> {
    let mut perm = fs::metadata(path)?.permissions();
    perm.set_mode(0o700); // Problematic line!
    fs::set_permissions(path, perm)?;
    Ok(())
}

#[cfg(windows)]
fn set_executable_permission(path: &Path) -> Result<()> {
    // Implement windows specific executable permission
    Ok(())
}

Explanation of suggested code:

• #[cfg(not(windows))] and #[cfg(windows)]: These attributes conditionally compile code based on the target OS. The code within the #[cfg(not(windows))] block will only be compiled when the target OS is not Windows. The code within the #[cfg(windows)] block will only be compiled when the target OS is Windows.
• Inside #[cfg(windows)], there's a placeholder comment. You'll need to find the appropriate Windows API calls to set the executable permission on the file.
• Note that the use std::os::unix::prelude::PermissionsExt; line should probably also be guarded by a #[cfg(not(windows))] attribute.

How to Fix:

1. Conditional Compilation: Wrap the Unix-specific code with #[cfg(unix)] or #[cfg(not(windows))] attributes. This will exclude that code from being compiled when building for Windows.
2. Windows Implementation: Provide an alternative implementation for setting executable permissions that uses Windows API calls. This might involve using the SetFileSecurity or chmod functions (available through crates like winapi or permissions_rs).
3. Dependencies: If you introduce new dependencies for the Windows implementation (like winapi), make sure they are also conditionally included using #[cfg(windows)] in your Cargo.toml.

Example Cargo.toml modification (if you need winapi):

[dependencies]
# ... other dependencies ...

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["fileapi", "security"] }

Important Considerations:

• Cross-Platform Compatibility: The goal is to make dagger-sdk work seamlessly on both Unix-like systems and Windows. Carefully consider the differences in file permission models and provide appropriate implementations for each platform.
• Testing: Thoroughly test the changes on both Windows and Unix-like systems to ensure that file permissions are handled correctly.

Log output

   Compiling dagger-sdk v0.18.3
error[E0433]: failed to resolve: could not find `unix` in `os`
  --> C:\Users\ADMIN\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\dagger-sdk-0.18.3\src\core\downloader.rs:4:9
   |
4  |     os::unix::prelude::PermissionsExt,
   |         ^^^^ could not find `unix` in `os`
   |
note: found an item that was configured out
  --> C:\Users\ADMIN\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib/rustlib/src/rust\library\std\src\os\mod.rs:36:9
   |
36 | pub mod unix {}
   |         ^^^^
note: the item is gated here
  --> C:\Users\ADMIN\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib/rustlib/src/rust\library\std\src\os\mod.rs:28:1
   |
28 | / #[cfg(all(
29 | |     doc,
30 | |     any(
31 | |         all(target_arch = "wasm32", not(target_os = "wasi")),
...  |
34 | | ))]
   | |___^
note: found an item that was configured out
  --> C:\Users\ADMIN\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib/rustlib/src/rust\library\std\src\os\mod.rs:85:9
   |
85 | pub mod unix;
   |         ^^^^
note: the item is gated here
  --> C:\Users\ADMIN\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib/rustlib/src/rust\library\std\src\os\mod.rs:84:1
   |
84 | #[cfg(all(not(target_os = "hermit"), any(unix, doc)))]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0599]: no method named `set_mode` found for struct `Permissions` in the current scope
   --> C:\Users\ADMIN\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\dagger-sdk-0.18.3\src\core\downloader.rs:157:14
    |
157 |         perm.set_mode(0o700);
    |              ^^^^^^^^ method not found in `Permissions`

Some errors have detailed explanations: E0433, E0599.
For more information about an error, try `rustc --explain E0433`.
error: could not compile `dagger-sdk` (lib) due to 2 previous errors