-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: .NET 10 Support #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the NetEvolve.Arguments library's target framework support and restructures README documentation. The main library now targets netstandard2.0, net8.0, net9.0, and net10.0 (removing net7.0), with corresponding unit test updates. README.md is reorganized from method-specific notes into a comprehensive multi-section overview including installation, usage examples, and framework compatibility. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds .NET 10.0 support to the NetEvolve.Arguments library, marking it as a breaking change feature. The changes are focused on expanding the multi-targeting capabilities to include the latest .NET framework version.
Key Changes
- Added
net10.0to target frameworks for both the main library and test project - Updated README.md with comprehensive documentation overhaul including .NET 10.0 support
- Enhanced documentation with detailed examples, installation instructions, and framework compatibility table
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/NetEvolve.Arguments/NetEvolve.Arguments.csproj |
Added net10.0 to TargetFrameworks alongside existing netstandard2.0, net7.0, net8.0, and net9.0 |
tests/NetEvolve.Arguments.Tests.Unit/NetEvolve.Arguments.Tests.Unit.csproj |
Added net10.0 to test project TargetFrameworks alongside net8.0 and net9.0 |
README.md |
Completely restructured with badges, comprehensive method documentation, usage examples, and framework compatibility table including .NET 10.0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 11 11
Lines 27 27
Branches 2 2
=======================================
Hits 26 26
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
63-63: ---Documentation restructuring is well-executed with verified external references.
The multi-section layout effectively communicates the library's purpose and API surface. The Framework Compatibility table correctly reflects all four supported targets (.NET Standard 2.0, .NET 8.0, .NET 9.0, .NET 10.0). The method reference sections are comprehensive, with consistent documentation patterns and clear code examples.
Microsoft Learn documentation links for
ArgumentNullException.ThrowIfNull,ArgumentOutOfRangeException.ThrowIfEqual, andArgumentException.ThrowIfNullOrEmptyhave been verified as current and active.Minor style consideration (optional): Line 200 currently reads "feel free to submit." Consider a more direct alternative such as "Contributions are welcome! Please submit issues, fork the repository, and create pull requests" for consistent professional tone.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (3)
README.md(1 hunks)src/NetEvolve.Arguments/NetEvolve.Arguments.csproj(1 hunks)tests/NetEvolve.Arguments.Tests.Unit/NetEvolve.Arguments.Tests.Unit.csproj(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~200-~200: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...ontributing Contributions are welcome! Please feel free to submit issues, fork the repository, and...
(FEEL_FREE_TO_STYLE_ME)
🔇 Additional comments (2)
tests/NetEvolve.Arguments.Tests.Unit/NetEvolve.Arguments.Tests.Unit.csproj (1)
3-3: Test framework targets correctly aligned with library updates.Adding net10.0 ensures test coverage for the newly supported .NET 10 framework. The test project targets align with the library's updated framework support.
src/NetEvolve.Arguments/NetEvolve.Arguments.csproj (1)
3-3: Framework support intentionally realigned to .NET 8–10 modernization strategy.The removal of net7.0 combined with the addition of net9.0 and net10.0, while maintaining netstandard2.0 support, reflects a modern-first approach. The Polyfill dependency remains appropriately scoped to netstandard2.0 (line 16), as newer frameworks provide native implementations.
Note: This is a breaking change for consumers targeting net7.0. Ensure this is communicated in release notes.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.