Skip to content

refactor: revert to old top readers logic #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

refactor: revert to old top readers logic #5087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755a890
refactor: revert to old top readers logic
AmarTrebinjac Nov 20, 2025
7f60906
add missing null check
AmarTrebinjac Nov 20, 2025
93ab7ff
update tests
AmarTrebinjac Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/shared/src/features/profile/components/ProfileWidgets/BadgesAndAwards.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ describe('BadgesAndAwards component', () => {
});

// Check summary cards
expect(screen.getByText('x8')).toBeInTheDocument(); // Total badges: 5 + 3
expect(screen.getByText('x5')).toBeInTheDocument();
expect(screen.getByText('Top reader badge')).toBeInTheDocument();

// Check badge items
Expand Down Expand Up @@ -245,7 +245,7 @@ describe('BadgesAndAwards component', () => {
renderComponent();

expect(screen.getByText('Badges & Awards')).toBeInTheDocument();
expect(screen.getByText('x8')).toBeInTheDocument(); // Total badges
expect(screen.getByText('x5')).toBeInTheDocument();
expect(screen.getByText('x0')).toBeInTheDocument(); // No awards
expect(screen.queryByAltText('Award')).not.toBeInTheDocument();
});
Expand Down
5 changes: 1 addition & 4 deletions packages/shared/src/features/profile/components/ProfileWidgets/BadgesAndAwards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ export const BadgesAndAwards = ({
return null;
}

const totalTopReaderBadges =
topReaders?.reduce((sum, topReader) => sum + (topReader?.total || 0), 0) ??
0;
const totalAwards =
awards?.reduce((sum, award) => sum + (award?.count || 0), 0) ?? 0;

Expand All @@ -86,7 +83,7 @@ export const BadgesAndAwards = ({

<div className="my-3 flex gap-3">
<SummaryCard
count={`x${totalTopReaderBadges}`}
count={`x${topReaders?.[0]?.total ?? 0}`}
label="Top reader badge"
/>
<SummaryCard count={`x${totalAwards}`} label="Total Awards" />
Expand Down