fix: remove duplicate handleOpportunityKeywordsUpdate function

- Export handleOpportunityKeywordsUpdate from parse.ts
- Remove duplicate implementation from opportunity.ts
- Add best practices section to AGENTS.md about avoiding duplication

Co-authored-by: Ido Shamun <idoshamun@users.noreply.github.com>

Author: github-actions[bot]

AGENTS.md

@@ -105,6 +105,14 @@ This file provides guidance to coding agents when working with code in this repo
 - `.infra/common.ts` - Worker subscription definitions
 - `.infra/index.ts` - Main Pulumi deployment configuration
 
+## Best Practices & Lessons Learned
+
+**Avoiding Code Duplication:**
+- **Always check for existing implementations** before creating new helper functions. Use Grep or Glob tools to search for similar function names or logic patterns across the codebase.
+- **Prefer extracting to common utilities** when logic needs to be shared. Place shared helpers in appropriate `src/common/` subdirectories (e.g., `src/common/opportunity/` for opportunity-related helpers).
+- **Export and import, don't duplicate**: When you need the same logic in multiple places, export the function from its original location and import it where needed. This ensures a single source of truth and prevents maintenance issues.
+- **Example lesson**: When implementing `handleOpportunityKeywordsUpdate`, the function was duplicated in both `src/common/opportunity/parse.ts` and `src/schema/opportunity.ts`. This caused lint failures and maintenance burden. The correct approach was to export it from `parse.ts` and import it in `opportunity.ts`.
+
 ## Pull Requests
 
 Keep PR descriptions concise and to the point. Reviewers should not be exhausted by lengthy explanations.

src/common/opportunity/parse.ts

@@ -368,7 +368,7 @@ export interface UpdateOpportunityContext {
  * Handles opportunity keywords updates
  * Replaces all existing keywords with the new set
  */
-async function handleOpportunityKeywordsUpdate(
+export async function handleOpportunityKeywordsUpdate(
   entityManager: EntityManager,
   opportunityId: string,
   keywords: Array<{ keyword: string }> | undefined,

src/schema/opportunity.ts

@@ -103,6 +103,7 @@ import {
   parseOpportunityWithBrokkr,
   createOpportunityFromParsedData,
   updateOpportunityFromParsedData,
+  handleOpportunityKeywordsUpdate,
 } from '../common/opportunity/parse';
 import {
   isMockEnabled,
@@ -1115,31 +1116,6 @@ async function handleOpportunityLocationUpdate(
   }
 }
 
-/**
- * Handles opportunity keywords updates
- * Replaces all existing keywords with the new set
- */
-async function handleOpportunityKeywordsUpdate(
-  entityManager: EntityManager,
-  opportunityId: string,
-  keywords: Array<{ keyword: string }> | undefined,
-): Promise<void> {
-  if (!Array.isArray(keywords)) {
-    return;
-  }
-
-  await entityManager.getRepository(OpportunityKeyword).delete({
-    opportunityId,
-  });
-
-  await entityManager.getRepository(OpportunityKeyword).insert(
-    keywords.map((keyword) => ({
-      opportunityId,
-      keyword: keyword.keyword,
-    })),
-  );
-}
-
 /**
  * Handles opportunity screening questions updates
  * Validates questions ownership and upserts them with proper ordering