Skip to content

refactor: no longer limit anonymous users on experience #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2025
Merged

refactor: no longer limit anonymous users on experience #3298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0444eeb
refactor: no longer limit anonymous users on experience
AmarTrebinjac Nov 21, 2025
ce77059
remove irrelevant test
AmarTrebinjac Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions __tests__/schema/profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,6 @@ describe('query userExperiences', () => {
expect(res.data.userExperiences.pageInfo.hasNextPage).toBe(false);
});

it('should return only 1 experience for non-logged-in user', async () => {
loggedUser = null;

const res = await client.query(USER_EXPERIENCES_QUERY, {
variables: { userId: '1' },
});

expect(res.errors).toBeFalsy();
expect(res.data.userExperiences.edges).toHaveLength(1);
});

it('should return all fields for logged-in users', async () => {
loggedUser = '1';

Expand Down
9 changes: 3 additions & 6 deletions src/schema/profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,8 @@ export const resolvers = traceResolvers<unknown, AuthContext>({
ctx,
info,
(nodeSize) =>
!!ctx.userId &&
userExperiencesPageGenerator.hasPreviousPage(page, nodeSize),
(nodeSize) =>
!!ctx.userId &&
userExperiencesPageGenerator.hasNextPage(page, nodeSize),
(nodeSize) => userExperiencesPageGenerator.hasNextPage(page, nodeSize),
(node, index) =>
userExperiencesPageGenerator.nodeToCursor(page, args, node, index),
(builder) => {
Expand All @@ -259,8 +256,8 @@ export const resolvers = traceResolvers<unknown, AuthContext>({
builder.queryBuilder
.orderBy(`${builder.alias}."endedAt"`, 'DESC', 'NULLS FIRST')
.addOrderBy(`${builder.alias}."startedAt"`, 'DESC')
.limit(!ctx.userId ? 1 : getLimit({ limit: page.limit }))
.offset(!ctx.userId ? 0 : page.offset);
.limit(getLimit({ limit: page.limit }))
.offset(page.offset);

return builder;
},
Expand Down
Loading