Remove profiler IDs and use ORM name as the index instead #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 12, 2015 23:02
Also remove the enums, which made it harder to subclass and communize code
daj
added a commit
that referenced
this pull request
May 13, 2015
Remove profiler IDs and use ORM name as the index instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on this suggestion: #2 (comment)
When adding new benchmarks it is easy to forget to update the profiler ID, so let's try to remove it.
As part of this change, I've removed the enums, which made it harder to subclass to share code.
@JogahCR, @MazyNoc please can one of you review this change?