Fix #609: Fix reading Transit response stream if data isn't available… #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht away InputStream .available only checks if data is available to read right now. It is possible that data becomes available leter. Read method (used by Transit internally) will block untill data is available or the stream is closed. It is best to let Transit read the stream. Empty streams throws an exception with Transit, but we can catch that specific case and return nil like previously. Two test cases test the existing functionality, and third new test case checks that Transit data is read correctly when the data becomes available a bit later.
Owner
|
Merged, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… right-away
InputStream .available only checks if data is available to read right
now. It is possible that data becomes available leter. Read method (used
by Transit internally) will block untill data is available or the stream
is closed.
It is best to let Transit read the stream. Empty streams throws an
exception with Transit, but we can catch that specific case and return
nil like previously.
Two test cases test the existing functionality, and third new test case
checks that Transit data is read correctly when the data becomes
available a bit later.