Skip to content

Conversation

@GideonPARANOID
Copy link

An icon isn't enough for a lot of screenreaders to infer what an action does, so introduced captions for screenreaders to the table header previous/next buttons.

Gideon MW Jones added 2 commits November 11, 2015 11:33
Added captions for screenreaders to the table header previous/next buttons.
Copied/pasted from Bootstrap.
@dalelotts
Copy link
Owner

Thanks for the PR - please submit to develop and write a test for this feature per the contributing guidelines.

@dalelotts dalelotts closed this Nov 16, 2015
@dalelotts
Copy link
Owner

I also noticed that this will not work for any language other than english. How would you suggest supporting other languages?

@GideonPARANOID
Copy link
Author

That's a good point. I guess how that is handled is dependent a bit on how the rest of the directive deals with language. Having had a look around, I don't see anything about language support. This probably wouldn't be too much work to get in, as Moment supports i18n.

Back to this case, I guess a lookup table would be the way I'd approach it, using something like this as a reference.

@dalelotts
Copy link
Owner

Yeah, this directive gets all of its L10n / i18n support from moment, so no additional logic has been needed. This would be the first change that will require some localization.

@GideonPARANOID
Copy link
Author

I've put a few of these comments into action & opened a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants