Skip to content

Conversation

kabilar
Copy link
Member

@kabilar kabilar commented Aug 11, 2025

@kabilar kabilar self-assigned this Aug 11, 2025
@kabilar kabilar changed the title [WIP] Add governance document Add DANDI governance document Sep 9, 2025
@kabilar kabilar marked this pull request as ready for review September 9, 2025 16:55
kabilar and others added 4 commits September 9, 2025 17:27
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
kabilar and others added 2 commits September 9, 2025 17:31
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>

## 7. Pull Request Workflow

### 7.1 Pull Request Requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it takes 30 days minimum to properly amend this doc, IMO we should move pull request requirements, draft-pr policy and possibly release process into the developers guide.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmacdo That's fair but I kept this here because we have had discussions on who should merge, when merges should happen, etc. so I think that all aspects of pull requests should be discussed here.

Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@kabilar
Copy link
Member Author

kabilar commented Sep 17, 2025

Hi @satra @waxlamp @jjnesbitt @mvandenburgh @candleindark @bendichter @djarecka, could you please take a look at this doc when you get a chance. Thanks.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nearly complete pass

Comment on lines +30 to +34
- A cloud-based platform to store, process, and disseminate data. You can use DANDI to collaborate and publish datasets.
- Open access to data to enable secondary uses of data outside the intent of the study.
- Optimize data storage and access through partnerships, compression and accessibility technologies.
- Enables reproducible practices and publications through data standards such as NWB and BIDS.
- The platform is not just an endpoint to dump data, it is intended as a living repository that enables collaboration within and across labs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening is "DANDI provides:" so IMHO all items should be continuations to such an opening, thus:

Suggested change
- A cloud-based platform to store, process, and disseminate data. You can use DANDI to collaborate and publish datasets.
- Open access to data to enable secondary uses of data outside the intent of the study.
- Optimize data storage and access through partnerships, compression and accessibility technologies.
- Enables reproducible practices and publications through data standards such as NWB and BIDS.
- The platform is not just an endpoint to dump data, it is intended as a living repository that enables collaboration within and across labs.
- a cloud-based platform to store, process, and disseminate data. You can use DANDI to collaborate and publish datasets.
- open access to data to enable secondary uses of data outside the intent of the study;
- optimized data storage and access through partnerships, compression and accessibility technologies;
- facilities to encourage reproducible practices and publications through data standards such as NWB and BIDS;
- a platform that is not just an endpoint to dump data, but intended to be a living repository that enables collaboration within and across labs.

or redo opening somehow differently ("DANDI is" ...)

## 3. Core Principles

1. Openness & Transparency: Designs, discussions, and decisions are public by default
2. FAIR & Reproducibility: Data and code evolution remain traceable and citable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. FAIR & Reproducibility: Data and code evolution remain traceable and citable
2. FAIR & Reproducibility: Data and code follow standards and their evolution remain open, traceable, and citable

since IMHO standards are the core of FAIR

### 5.1 Contributors
Anyone submitting issues, pull requests, documentation, or feedback.
Responsibilities:
- Follow Code of Conduct and contribution guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to follow if no references! Will they be per project or generic?

Anyone submitting issues, pull requests, documentation, or feedback.
Responsibilities:
- Follow Code of Conduct and contribution guidelines
- Provide context and reproducible steps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Provide context and reproducible steps
- Strive to provide sufficient context and steps to reproduce


### 5.2 Reviewers
Contributors granted reviewer status for designated repositories.
Responsibilities:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Responsibilities:
Responsibilities:

Expectations:
- Active presence
- Adhere to conflict of interest and bias avoidance
Path to role:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Path to role:
Path to role:

## 6. Decision-Making Model

### 6.1 Roadmap
- Project targets are discussed during the biweekly Engineering Core and Scientific Core meetings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, make trailing . uniform across listings. Above sections didn't have them, and here they come. Just add them all over

### 7.2 Merge Policy
- All pull requests require:
- All comments must be resolved or addressed
- Approval by at least 1 listed Maintainer for that repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"listed" where?

how do we resolve road-blocks? e.g. Project Leadership could have a decree to approve/disprove?

- All pull requests require:
- All comments must be resolved or addressed
- Approval by at least 1 listed Maintainer for that repository
- 24 hour waiting period (unless addressing a critical issue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 24 hour waiting period (unless addressing a critical issue)
- 24 hour waiting period (unless addressing a critical issue or obviously trivial)

? so that some typo in comment could be fixed without waiting/forgetting

- Convert to “Ready” only when tests and documentation are updated

### 7.4 Reverts
- Any Maintainer may revert a merged pull request causing regression, security issue, or service degradation, with immediate notice in original pull request thread.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"almost", release might not be needed if prior change was not even released yet. so state not "must be made" but "must be made if prior change was already released"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants