-
Notifications
You must be signed in to change notification settings - Fork 228
Adding a parameter to allow graphs to be bounded #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a parameter to allow graphs to be bounded #382
Conversation
… node outside the viewport)
|
@danielcaldas How can I generate the documentation for the sandbox? I can see the parameter but running npm run docs does not generate the tooltip with the documentation, and does not seem to write in the JSON files. |
Sorry won't have much time to look into this one for some weeks. To generate documentation give a try to: npm run generate:tooltipsThis job runs the script that generates the static data file for the sandbox tooltips. But usually tooltips data update is part of the release process when we release a new version of the sandbox with |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@danielcaldas , I allowed myself to remove the won't fix label as it should still fix an issue. |
terahn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
danielcaldas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more small refactor and it's ready to go 🚀
danielcaldas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Hi, I saw your PR is merged to master. Can you please update the prop which we need to add for the fit to the window of the graph? |
Hi @onlyreddy, this will be documented once we publish a new version of |
Implementing feature request #285
This does not have an effect when zooming or even moving the graph around, only when moving nodes.
A complete version could be implemented to keep the entire graph in the viewport but in my opinion, it would be very annoying when trying to zoom on a graph with a lot of elements since it would prevent the graph to be zoomed at some point.