Skip to content

Conversation

@antoninklopp
Copy link
Collaborator

@antoninklopp antoninklopp commented Oct 11, 2020

Implementing feature request #285

This does not have an effect when zooming or even moving the graph around, only when moving nodes.
A complete version could be implemented to keep the entire graph in the viewport but in my opinion, it would be very annoying when trying to zoom on a graph with a lot of elements since it would prevent the graph to be zoomed at some point.

⚠️ This Pull Request does not implement the boundary restriction when creating nodes.

@antoninklopp
Copy link
Collaborator Author

@danielcaldas How can I generate the documentation for the sandbox? I can see the parameter but running npm run docs does not generate the tooltip with the documentation, and does not seem to write in the JSON files.

@danielcaldas
Copy link
Owner

@danielcaldas How can I generate the documentation for the sandbox? I can see the parameter but running npm run docs does not generate the tooltip with the documentation, and does not seem to write in the JSON files.

Sorry won't have much time to look into this one for some weeks.

To generate documentation give a try to:

npm run generate:tooltips

This job runs the script that generates the static data file for the sandbox tooltips.

But usually tooltips data update is part of the release process when we release a new version of the sandbox with npm run dist.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@antoninklopp
Copy link
Collaborator Author

@danielcaldas , I allowed myself to remove the won't fix label as it should still fix an issue.

Copy link
Collaborator

@terahn terahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small refactor and it's ready to go 🚀

Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@onlyreddy
Copy link

Hi,

I saw your PR is merged to master. Can you please update the prop which we need to add for the fit to the window of the graph?

@danielcaldas
Copy link
Owner

Hi,

I saw your PR is merged to master. Can you please update the prop which we need to add for the fit to the window of the graph?

Hi @onlyreddy, this will be documented once we publish a new version of react-d3-graph. Cheers!

@danielcaldas danielcaldas merged commit 662f386 into danielcaldas:master Mar 18, 2021
@antoninklopp antoninklopp deleted the feature/bounded-graph-no-zoom branch March 18, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants