feat: Add Google OAuth 2.0 login feature #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements third-party authentication using Google OAuth 2.0.
Key changes include:
- Added Passport.js strategy for Google OAuth (`passport-google-oauth20`).
- Updated User model (`prisma/schema.prisma`) to include `googleId` and `provider` fields. Hash made optional.
IMPORTANT: You'll need to run database migrations manually via `npx prisma migrate dev`.
- Modified `AuthModule`, `AuthController`, and `AuthService` to support the Google login flow:
- New routes: `/auth/google` and `/auth/google/callback`.
- `AuthService.validateOAuthLogin` handles user lookup/creation based on Google profile.
- Existing `signup` and `signin` adjusted for OAuth users.
- Added required environment variables (`GOOGLE_CLIENT_ID`, `GOOGLE_CLIENT_SECRET`, `GOOGLE_CALLBACK_URL`) to `.env` and `.env.test`.
IMPORTANT: You must configure these variables with actual credentials from Google Cloud Console.
- Implemented e2e tests (`test/app.e2e-spec.ts`) for the Google login flow, covering:
- New user registration via Google.
- Login for existing Google users.
- Linking Google account to an existing local user.
- Tests utilize mocking for service layer dependencies and direct controller invocation for callback handling due to OAuth complexities in e2e.
Manual steps required post-pull:
1. Run database migrations: `npx prisma migrate dev --name add_google_auth_to_user` (or a similar name if you prefer).
2. Configure environment variables in `.env` with your Google Cloud OAuth credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements third-party authentication using Google OAuth 2.0.
Key changes include:
passport-google-oauth20).prisma/schema.prisma) to includegoogleIdandproviderfields. Hash made optional. IMPORTANT: You'll need to run database migrations manually vianpx prisma migrate dev.AuthModule,AuthController, andAuthServiceto support the Google login flow:/auth/googleand/auth/google/callback.AuthService.validateOAuthLoginhandles user lookup/creation based on Google profile.signupandsigninadjusted for OAuth users.GOOGLE_CLIENT_ID,GOOGLE_CLIENT_SECRET,GOOGLE_CALLBACK_URL) to.envand.env.test. IMPORTANT: You must configure these variables with actual credentials from Google Cloud Console.test/app.e2e-spec.ts) for the Google login flow, covering:Manual steps required post-pull:
npx prisma migrate dev --name add_google_auth_to_user(or a similar name if you prefer)..envwith your Google Cloud OAuth credentials.