Skip to content

add getnewargs_ex to Enum, fix pickling #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025
Merged

add getnewargs_ex to Enum, fix pickling #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db17f0c
add getnewargs_ex to Enum, fix pickling
benedikt-bartscher Mar 29, 2025
ce1e042
add minimal test for enum pickling
benedikt-bartscher Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/betterproto/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ def __new__(cls, *, name: Optional[str], value: int) -> Self:
super().__setattr__(self, "value", value)
return self

def __getnewargs_ex__(self) -> Tuple[Tuple[()], Dict[str, Any]]:
return (), {"name": self.name, "value": self.value}

def __str__(self) -> str:
return self.name or "None"

Expand Down
13 changes: 13 additions & 0 deletions tests/test_pickling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ class Complex(betterproto.Message):
)


class BetterprotoEnum(betterproto.Enum):
UNSPECIFIED = 0
ONE = 1


def complex_msg():
return Complex(
foo_str="yep",
Expand Down Expand Up @@ -201,3 +206,11 @@ def use_cache():
.string_value
== "world"
)


def test_pickle_enum():
enum = BetterprotoEnum.ONE
assert unpickled(enum) == enum

enum = BetterprotoEnum.UNSPECIFIED
assert unpickled(enum) == enum
Loading