IntrospectionProcessor __invoke Doesn't Hit With the Stack Logging Channel

[chunterb]

Hello,

First off, thank you for this awesome package - it is saving me a lot of work. I am having to customize it to our needs, but it works really well to begin with.

I have stumbled across a problem, and this is tested on a fresh install to assure that it is not my mistake.

The problem is that when you turn on the 'stack' channel for logging, the IntrospectionProcessor __invoke never gets hit, causing all of the logs to exclude the IntrospectionProcessor (file, class, etc..).

It seems that it tries to hit the local channels, before the database channel. After that, it uses the formatting for the local channel instead of the formatting for the DB logger. Not sure if this could be overridden - if that's the case.

Am I missing something here?

[danielme85]

Hi @chunterb,
I think you are on to something here, it does seem to behave differently when using the 'stack' channel.

/**
 * Class LogToDbHandler
 *
 * @package danielme85\LaravelLogToDB
 */
class LogToDbHandler
{
    /**
     * Create a custom Monolog instance.
     *
     * @param  array  $config
     * @return \Monolog\Logger
     */
    public function __invoke(array $config)
    {
        return new Logger(
            $config['name'] ?? 'LogToDB', // <- this is missing as well :(
            [
                // The log handler class gets passed along fine
                new LogToDbCustomLoggingHandler(
                    $config['connection'] ?? null,
                    $config['collection'] ?? null,
                    $config['detailed'] ?? null,
                    $config['queue'] ?? null,
                    $config['queue_name'] ?? null,
                    $config['queue_connection'] ?? null,
                    $config['level'] ?? null)
            ],
            [
                new IntrospectionProcessor() // <- there is our missing friend :(
            ]);
    }
}

The $config['name'] is missing when new Logger class is called trough the 'stack' channel, so the same thing might be happening to the IntrospectionProcessor...?
I'l try to look into this sometime this week: my first guess would be that maybe there is some 'stack' logic that calls a new Logger class after LogToDbHandler and/or maybe the Logger class is passed along from channel to channel?

Thank you for letting me know about this issue, and for your compliment (you might want to save that for when we actually get this working correctly 😛).
Any help/feedback would definitely be welcome!

[chunterb]

@danielme85

So, I have found this much...

When using the stack driver with the database channel, it looks to be calling a different handler.

To see for yourself:

Line 208 on Illuiminate\Log\LogManager.php

    /**
     * Create an aggregate log driver instance.
     *
     * @param  array  $config
     * @return \Psr\Log\LoggerInterface
     */
    protected function createStackDriver(array $config)
    {
        $handlers = collect($config['channels'])->flatMap(function ($channel) {
            return $this->channel($channel)->getHandlers();
        })->all();

        if ($config['ignore_exceptions'] ?? false) {
            $handlers = [new WhatFailureGroupHandler($handlers)];
        }

        dd($handlers);

        return new Monolog($this->parseChannel($config), $handlers);
    }

This outputs:

array:2 [▼
  0 => RotatingFileHandler {#191 ▶}
  1 => LogToDbCustomLoggingHandler {#197 ▶}
}

From my understanding, the LogToDbHandler.php is where the Introspect Processor gets called, but it doesnt seem to be hitting that handler when using stack.

Hope this is somewhat helpful.

[danielme85]

Thanks, that seems like the perfect place to start my debugging.
Please let me know if you have any success, and I will do the same.

[danielme85]

@chunterb, Could you checkout the dev branch and see if that works better for you? c725ae5

Turns out there is a pushProcessor() function on the Monolog Handler class, hopefully that would fix it.

[danielme85]

Hopefully fixed by 14bb8fc