Skip to content

Conversation

@chrchr-github
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator

Somebody changed the msbuild builds to using CMake instead so the Visual Studio project files are no longer being checked by the CI at all. That change should be reverted.

I would be in favor of just removing the Visual Studio project files since CMake can generate them but they are not fully aligned yet - another task on my endless TODO list I will never get to since I have already disappeared again...

@chrchr-github
Copy link
Collaborator Author

Well, the release-windows build still relies on the project files... (and is therefore broken right now)

@danmar danmar merged commit 474c3d3 into danmar:main Oct 11, 2021
@danmar
Copy link
Owner

danmar commented Oct 11, 2021

Well, the release-windows build still relies on the project files... (and is therefore broken right now)

I don't know there might be good reasons to use the vs projects in the release build. I guess there might be optimisation options not available through cmake.

I believe it would be interesting to try out the visual studio clang integration.

@chrchr-github
Copy link
Collaborator Author

The existing project files are also nicer than what CMake generates (IMHO the targets in those files are somewhat confusing).

@firewave
Copy link
Collaborator

I believe it would be interesting to try out the visual studio clang integration.

Using clang-cl is a totally different task ...

The existing project files are also nicer than what CMake generates (IMHO the targets in those files are somewhat confusing).

Still? :(
I remember that being the main reason to not use the generated ones.

@chrchr-github
Copy link
Collaborator Author

CMake:
image
Native:
image
I think the 3 native projects are what the user wants to use 99% of the time.

@firewave
Copy link
Collaborator

If we rework CMake a bit we can probably get closer to that.

@chrchr-github chrchr-github deleted the chr_FixMSVCBuild branch October 28, 2021 15:18
@chrchr-github chrchr-github mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants