use Python version provided by platform in CI / prefer python3 #3776
Conversation
firewave
force-pushed
the
py
branch
2 times, most recently
from
cd42634 to
dfb21f2
Compare
firewave
changed the title
| find_package(PythonInterp 3 QUIET) | ||
| if (NOT PYTHONINTERP_FOUND) | ||
| set(PYTHONINTERP_FOUND "") | ||
| find_package(PythonInterp 2.7 QUIET) |
There was a problem hiding this comment.
feel free to drop support for python 2.7 in the match compiler. you can do it in a follow up PR.
There was a problem hiding this comment.
Alright.
But I still think we should drop Python 2.7 as a whole and not just in parts. We still have holes in the CI matrix with that and I'd rather remove stuff from it than add more.
There was a problem hiding this comment.
I hope we can still find some CI-runner that has python 2.7. I also hope that it doesn't cost much to keep some user-scripts compatible with python 2.7 for a little while.
There was a problem hiding this comment.
That's no problem at all. Ubuntu 18.04 and 20.04 both still have it. And we also get it via the GitHub Action plugin and use it in the scriptcheck job.
There's also plenty of docker images available.
2 participants
The user might not have the option to install another Python version unlike our CI. So we should use the version provided by the platform to make sure we can actually compile on it.