aligned build options of Visual Studio project configurations and added them to CMake #4020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
firewave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I aligned the options which were different in-between the Visual Studio configurations (i.e.
Release/Release-PCREandDebug/Debug-PCRE). If these were changed manually and are matching the default value they will also be shown as changed so there's possibly a few we can drop and clean up things a bit more in the future.I also reviewed all the options in the Visual Studio projects which are being highlighted as changed (the bold ones) and added them to CMake. Some of the option did not show a corresponding command-line option so those still need to be looked into at a later date.
This also fixes the remaining build issues of #3919 and #3925 caused by (yet another) incorrect C++ standard in the Visual Studio
Debug-PCREconfiguration ofcppcheck.