Skip to content

Conversation

@Alon-Alexander
Copy link
Contributor

Currently, move/copy constructors are checked as function names.
For example, if someone does not name their functions with the same standard as their class names, the tool will report an error.

This fix makes the function name-checking ignore both copy and move constructors.

@firewave
Copy link
Collaborator

Thanks for your contribution. Please also add a unit test for this to addons/test/naming_test.cpp.

Please be aware that those are currently not part of the CI. Also please ignore all existing failures - they are known and need to be addressed. More about that in #3715.

@firewave
Copy link
Collaborator

Thanks.

I also finally got the PR which adds the tests to the CI ready. I think we should get that in first before merging this.

BTW how do you want to be credited as in the AUTHORS file? @danmar

@firewave
Copy link
Collaborator

Please rebase - the tests are now run in the CI again.

@Alon-Alexander Alon-Alexander force-pushed the bugfix/constructors_in_naming_addon branch from e80932a to b2adc30 Compare May 31, 2022 22:06
@Alon-Alexander
Copy link
Contributor Author

Regarding the AUTHORS file, I am really appreciated that even for such a small contribution you give such credit. It is definitely motivating to keep contributing to the project!
I would like to be credited as Alon Alexander.

@orbitcowboy orbitcowboy merged commit ea3bb8b into danmar:main Jun 1, 2022
@Alon-Alexander Alon-Alexander deleted the bugfix/constructors_in_naming_addon branch June 7, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants