fixed some CLion inspection warnings #4688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
firewave
changed the title
… value is never used" warning
| mUI->mComboBoxPlatform->setCurrentText(projectFile->getPlatform()); | ||
| setSuppressions(projectFile->getSuppressions()); | ||
|
|
||
| // TODO |
Collaborator
There was a problem hiding this comment.
Why not remove the comment block?
Collaborator
Author
There was a problem hiding this comment.
Because I didn't look into why it is commented.
| QStringList getCheckUnknownFunctionReturn() const { | ||
| return mCheckUnknownFunctionReturn; | ||
| } | ||
| void setCheckUnknownFunctionReturn(const QStringList &s) { |
Collaborator
There was a problem hiding this comment.
Why is this a comment?
Collaborator
Author
There was a problem hiding this comment.
Because the code which uses it is commented out. It's the one I added the TODO to.
chrchr-github
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am open to keeping some things but I had these changes sitting in a branch for well over a year now and those things are still not used yet so it should be fair game to remove them.