Skip to content

Fix #10976 false negative: autoVariables [inconclusive] (regression) #5044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2023
Merged

Fix #10976 false negative: autoVariables [inconclusive] (regression) #5044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdc867c
Fix #10976 false negative: autoVariables [inconclusive] (regression)
chrchr-github May 9, 2023
b3f0340
Use link()
chrchr-github May 9, 2023
29b43be
Use linkAt()
chrchr-github May 9, 2023
286e337
Skip over [][]
chrchr-github May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/checkautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,12 @@ bool CheckAutoVariables::checkAutoVariableAssignment(const Token *expr, bool inc
}
if (Token::simpleMatch(tok, "=")) {
const Token *lhs = tok;
while (Token::Match(lhs->previous(), "%name%|.|*"))
lhs = lhs->previous();
while (Token::Match(lhs->previous(), "%name%|.|*|]")) {
if (lhs->linkAt(-1))
lhs = lhs->linkAt(-1);
else
lhs = lhs->previous();
}
const Token *e = expr;
while (e->str() != "=" && lhs->str() == e->str()) {
e = e->next();
Expand Down
12 changes: 12 additions & 0 deletions test/testautovariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,18 @@ class TestAutoVariables : public TestFixture {
" pcb->root0 = 0;\n" // <- conditional reassign => error
"}");
ASSERT_EQUALS("[test.cpp:3]: (error) Address of local auto-variable assigned to a function parameter.\n", errout.str());

check("struct S { int *p; };\n"
"void g(struct S* s) {\n"
" int a[10];\n"
" s->p = a;\n"
" a[0] = 0;\n"
"}\n"
"void f() {\n"
" struct S s;\n"
" g(&s);\n"
"}");
ASSERT_EQUALS("[test.cpp:4]: (error, inconclusive) Address of local auto-variable assigned to a function parameter.\n", errout.str());
}

void testinvaliddealloc() {
Expand Down