improved determination if application is Premium / added TODOs #7346

firewave · 2025-03-01T14:29:42Z

No description provided.

firewave · 2025-03-01T14:32:13Z

cli/cmdlineparser.cpp

+    const std::string manualUrl(premium ?
+                                "https://files.cppchecksolutions.com/manual.pdf" :
+                                "https://cppcheck.sourceforge.io/manual.pdf");


These were switched.

Also we should not have the custom URL hardcoded and read it from cppcheck.cfg like the product name instead. I files https://trac.cppcheck.net/ticket/14208 about this.

test/cli/premium_test.py

firewave · 2025-03-01T14:39:47Z

This is in preparation of avoiding unmatchedSuppression with premium-* suppressions - see https://trac.cppcheck.net/ticket/13663.

It also gets rid of loading the cppcheck.cfg twice into the settings.

firewave · 2025-03-01T16:53:19Z

test/cli/premium_test.py

                    "productName": "NAME",
-                    "about": "NAME",
-                    "safety": true
+                    "about": "NAME"


This test was based on the behavior that is loaded cppcheck.cfg first and being overriden by the CLI. But that is not how it was initially implemented. That behavior changed when the double loading was introduced in #5760.

danmar · 2025-03-18T13:29:35Z

test/cli/premium_test.py

-    exitcode, _, stderr = cppcheck(['--xml-version=3', '--premium=safety-off', test_file], cppcheck_exe=exe)
+    exitcode, _, stderr = cppcheck(['--xml-version=3', test_file], cppcheck_exe=exe)
    assert exitcode == 0
    assert '<safety/>' not in stderr


Cppcheck Premium should enable safety by default. So I expect <safety/> in xml output unless it's explicitly turned off with --premium=safety-off.

Cppcheck Premium should enable safety by default.

That means that it is explicitly enabled in cppcheck.cfg, right? Should it even be allowed to be disabled by default if it is premium (i.e. <safety> is missing or set to false)?

What about --no-safety? May it also override the premium safety (default)? Or should that be limited to --premium=safety-off?

I would be fine having special handling for the safety flag. I just would have it properly defined.

@danmar I need feedback on this to proceed.

@danmar Still need feedback to be able to proceed.

That means that it is explicitly enabled in cppcheck.cfg, right?

yes.

Should it even be allowed to be disabled by default if it is premium (i.e. is missing or set to false)?

We can allow that it's off.

If the user provides --safety or --safety-off on the command line then those options should override what the cppcheck.cfg says.

imho if there is missing safety option in cppcheck.cfg then safety should be off by default.

my intention is that cppcheck.cfg is a general purpose interface so that everybody can customize cppcheck if they want to, maybe somebody wants that cppcheck will always execute certain extra addons.. there should be a minimum of cppcheck premium specific code in open source cppcheck.

@danmar Still need feedback to proceed.

FYI If this weren't premium-related I would have just defined things and merged it by now.

Thanks, I will get rid of any special handling.

That also makes safety within --premium redundant and I think we should deprecate/remove it.

danmar · 2025-03-18T13:31:55Z

test/cli/premium_test.py

+    exitcode, _, stderr = cppcheck(['--premium=autosar', '--xml', test_file], cppcheck_exe=exe)
    assert exitcode == 0
    assert 'id="unusedVariable"' in stderr
    assert 'id="checkersReport"' not in stderr


I expect to see checkersReport in the Cppcheck Premium output unless --premium=safety-off is provided.

That is because the config used in the test doesn't have safety set. The changes in this PR removed that it is always implicitly enabled.

Actually I removed it in the changes and inverted the checks. I reverted that change.

The actual problem is that cppcheck.cfg is read after the CLI options because of the assumption that the config should override those.

test/cli/premium_test.py

danmar

sorry I had this review comment pending.. hope it helps

danmar · 2025-06-12T14:00:16Z

test/cli/premium_test.py

-    exitcode, _, stderr = cppcheck(['--xml-version=3', '--premium=safety-off', test_file], cppcheck_exe=exe)
+    exitcode, _, stderr = cppcheck(['--xml-version=3', test_file], cppcheck_exe=exe)
    assert exitcode == 0
    assert '<safety/>' not in stderr


That means that it is explicitly enabled in cppcheck.cfg, right?

yes.

Should it even be allowed to be disabled by default if it is premium (i.e. is missing or set to false)?

We can allow that it's off.

If the user provides --safety or --safety-off on the command line then those options should override what the cppcheck.cfg says.

imho if there is missing safety option in cppcheck.cfg then safety should be off by default.

my intention is that cppcheck.cfg is a general purpose interface so that everybody can customize cppcheck if they want to, maybe somebody wants that cppcheck will always execute certain extra addons.. there should be a minimum of cppcheck premium specific code in open source cppcheck.

firewave · 2025-10-14T23:46:35Z

Looks like this is already complete.

I did not check if the non-premium and premium CLI flags are correctly working with each other. I think it is fine to assume that they are currently not being mixed and if we deprecate one set of them that should also not be an issue going forward.

sonarqubecloud · 2025-10-17T12:20:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

firewave · 2025-10-22T13:52:48Z

Anything still to do here? I have several follow-ups lined up.

danmar · 2025-10-25T12:17:48Z

gui/mainwindow.cpp

            return false;
        }

+        settings.premium = startsWith(settings.cppcheckCfgProductName, "Cppcheck Premium");


it feels like this line of code belongs in LIB?

firewave commented Mar 1, 2025

View reviewed changes

github-advanced-security bot found potential problems Mar 1, 2025

View reviewed changes

test/cli/premium_test.py Fixed Show fixed Hide fixed

firewave force-pushed the cmd-premium branch from 4692a9c to e27e877 Compare March 1, 2025 14:49

firewave marked this pull request as draft March 1, 2025 16:21

firewave force-pushed the cmd-premium branch from e27e877 to f1bb5ad Compare March 1, 2025 16:50

firewave commented Mar 1, 2025

View reviewed changes

firewave force-pushed the cmd-premium branch from f1bb5ad to f3f369c Compare March 1, 2025 16:57

firewave marked this pull request as ready for review March 1, 2025 16:58

firewave force-pushed the cmd-premium branch 2 times, most recently from b093636 to 7c9b217 Compare March 1, 2025 22:02

danmar reviewed Mar 18, 2025

View reviewed changes

firewave marked this pull request as draft March 19, 2025 08:15

firewave mentioned this pull request Jun 29, 2025

CI-unixish.yml: removed random usage of build dir from selfcheck #6938

Open

firewave force-pushed the cmd-premium branch 2 times, most recently from d342511 to 4979097 Compare September 25, 2025 10:31

firewave marked this pull request as ready for review September 25, 2025 10:31

github-advanced-security bot found potential problems Sep 25, 2025

View reviewed changes

test/cli/premium_test.py Dismissed Show dismissed Hide dismissed

danmar reviewed Oct 1, 2025

View reviewed changes

firewave mentioned this pull request Oct 11, 2025

Make it easier to disable process executor #7876

Open

firewave force-pushed the cmd-premium branch 4 times, most recently from b49b051 to e9acdd4 Compare October 15, 2025 02:41

firewave marked this pull request as draft October 15, 2025 03:02

firewave force-pushed the cmd-premium branch from 1f96076 to 6e8dd58 Compare October 15, 2025 11:52

firewave mentioned this pull request Oct 15, 2025

fixed handling of mixed slashes in Path::join() #7891

Merged

This comment was marked as resolved.

Sign in to view

firewave force-pushed the cmd-premium branch from a0f390d to 86eeee0 Compare October 15, 2025 18:25

firewave force-pushed the cmd-premium branch 3 times, most recently from 6ac9ee0 to aabc350 Compare October 15, 2025 19:12

firewave added 4 commits October 17, 2025 14:12

improved determination if application is Premium / added TODOs

2d1af4a

allow safety from config to be overwritten

48acb4c

test/cli: fixed tests utilizing cppcheck.cfg on Windows

a4c3d5f

ImportProject: removed premium parameters

2bb5cd5

firewave force-pushed the cmd-premium branch from aabc350 to 2bb5cd5 Compare October 17, 2025 12:13

firewave marked this pull request as ready for review October 17, 2025 12:13

danmar reviewed Oct 25, 2025

View reviewed changes

improved determination if application is Premium / added TODOs #7346

Are you sure you want to change the base?

improved determination if application is Premium / added TODOs #7346

Uh oh!

Conversation

firewave commented Mar 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

firewave commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danmar Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

danmar left a comment

Choose a reason for hiding this comment

Uh oh!

danmar Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

firewave commented Oct 14, 2025

Uh oh!

This comment was marked as resolved.

sonarqubecloud bot commented Oct 17, 2025

Quality Gate passed

Uh oh!

firewave commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

firewave commented Mar 1, 2025 •

edited

Loading

danmar Jun 12, 2025 •

edited

Loading

danmar Jun 12, 2025 •

edited

Loading