Skip to content

cleaned up includes based on include-what-you-use/clang-include-cleaner #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firewave merged 2 commits into from
Apr 7, 2025
Merged

cleaned up includes based on include-what-you-use/clang-include-cleaner #7437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d4eb0a
cleaned up includes based on include-what-you-use
firewave Mar 23, 2025
4591e34
json.h: added annotation for clang-include-cleaner
firewave Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/addoninfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <fstream>
#include <iostream>
#include <string>
#include <utility>

#include "json.h"

Expand Down
1 change: 0 additions & 1 deletion lib/checkleakautovar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "tokenize.h"
#include "tokenlist.h"
#include "utils.h"
#include "vfvalue.h"

#include <algorithm>
#include <array>
Expand Down
1 change: 0 additions & 1 deletion lib/forwardanalyzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include "tokenlist.h"
#include "utils.h"
#include "valueptr.h"
#include "vfvalue.h"

#include <algorithm>
#include <cassert>
Expand Down
2 changes: 1 addition & 1 deletion lib/json.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ SUPPRESS_WARNING_CLANG_PUSH("-Wformat")
SUPPRESS_WARNING_CLANG_PUSH("-Wfloat-conversion")

#define PICOJSON_USE_INT64
#include <picojson.h>
#include <picojson.h> // IWYU pragma: export
Copy link
Collaborator Author

@firewave firewave Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for clang-include-cleaner only (still need to file an upstream bug) - see include-what-you-use/include-what-you-use#1696 for some context why it should not be necessary.


SUPPRESS_WARNING_CLANG_POP
SUPPRESS_WARNING_CLANG_POP
Expand Down
6 changes: 6 additions & 0 deletions test/testexecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,18 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "errorlogger.h"
#include "errortypes.h"
#include "executor.h"
#include "filesettings.h"
#include "fixture.h"
#include "settings.h"
#include "suppressions.h"

#include <list>
#include <stdexcept>
#include <string>
#include <utility>

class DummyExecutor : public Executor
{
Expand Down
1 change: 1 addition & 0 deletions test/testsuppressions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "cppcheck.h"
#include "cppcheckexecutor.h"
#include "errorlogger.h"
#include "errortypes.h"
#include "filesettings.h"
#include "fixture.h"
Expand Down
1 change: 1 addition & 0 deletions test/testtoken.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "fixture.h"
#include "helpers.h"
#include "settings.h"
#include "standards.h"
#include "token.h"
#include "tokenlist.h"
Expand Down
Loading