Skip to content

path.cpp: fixed -Wuseless-cast GCC warning with C++17 #7771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

path.cpp: fixed -Wuseless-cast GCC warning with C++17 #7771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/path.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,15 @@
return false;
std::string buf(128, '\0');
{
#if __cplusplus >= 201703L
// C++17 provides an overload with non-const data()
#define CONST_CAST(x) (x)
#else
#define CONST_CAST(x) const_cast<char*>(x)
#endif
// TODO: read the whole first line only
const char * const res = fgets(const_cast<char*>(buf.data()), buf.size(), fp);
const char * const res = fgets(CONST_CAST(buf.data()), buf.size(), fp);
#undef CONST_CAST
fclose(fp);
fp = nullptr;
if (!res)
Expand Down