fix #14130: false positive: unusedStructMember with [[maybe_unused]] #7818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludviggunne
force-pushed
the
14130
branch
2 times, most recently
from
bfad711 to
4ad7c65
Compare
Collaborator
|
We should add more tests which cover the added functionality. |
firewave
reviewed
Sep 14, 2025
Collaborator
Author
Most of the additions came about from failing tests in other components, but I could add some others that are more specific. |
ludviggunne
force-pushed
the
14130
branch
2 times, most recently
from
b77f655 to
8f029d3
Compare
Collaborator
Good to know. Just looking at the changes this was not evident. So it should be fine then. |
Collaborator
Author
|
Oops, I included a commit that shouldn't be here, I'll remove it later tonight. Edit: Done. |
danmar
reviewed
Sep 25, 2025
danmar
approved these changes
Sep 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.