fixed #14197: Add float bits in platform #7886
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
a0e8fdf to
b68dd28
Compare
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
b68dd28 to
5ff8248
Compare
|
I guess you can disregard the deluge of signedness warnings. We currently do not care about them and have all the related compiler warnings disabled (I am not going to get into that discussion again but you are welcome to). |
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
5ff8248 to
91149bb
Compare
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
91149bb to
1252411
Compare
There was a problem hiding this comment.
Cppcheck Premium found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
you need to update the calculation in Platform::loadFromXmlDocument also.
It's not your fault but I feel it's insane that we copy paste the calculations in so many places. I would prefer a private method calculateBitMembers().
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
1252411 to
27d89a8
Compare
firewave
changed the title
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
these "Integral promotion and the usual arithmetic conversions shall not change the signedness or the type category of an operand" are unwanted. Please add suppression in the cppcheckpremium-suppressions file:
# integer promotions
premium-misra-cpp-2023-7.0.5
27d89a8 to
23d2add
Compare
swasti16
force-pushed
the
swasti/add_float_bits
branch
2 times, most recently
from
cf73d2f to
6a6a228
Compare
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
6a6a228 to
41e3aec
Compare
swasti16
force-pushed
the
swasti/add_float_bits
branch
from
41e3aec to
e4eb768
Compare
|
3 participants
No description provided.