Skip to content

Conversation

@0xda157
Copy link
Contributor

@0xda157 0xda157 commented Mar 3, 2025

fixes #186, fixes #185
cc: @trueNAHO

Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theme seems to be applied inside:

nix run github:awwpotato/stylix/init-mpv#testbed:mpv:uosc:light:image:scheme

image

However, it does not seem to be applied inside:

nix run github:awwpotato/stylix/init-mpv#testbed:mpv:default:light:image:scheme

image

Or is that the expected look?

@0xda157 0xda157 force-pushed the init-mpv branch 4 times, most recently from 373de66 to 07ca3b4 Compare March 8, 2025 21:59
@0xda157
Copy link
Contributor Author

0xda157 commented Mar 8, 2025

Or is that the expected look?

The config is mostly a copy of the catppuccin mpv thingy, I wasn't really able to find any other colorschemes to base it off of. It looks the same as the preview images in the catppuccin theme so I think that's as good as we're gonna get.

@0xda157 0xda157 requested a review from trueNAHO March 8, 2025 23:39
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config is mostly a copy of the catppuccin mpv thingy, I wasn't really able to find any other colorschemes to base it off of. It looks the same as the preview images in the catppuccin theme so I think that's as good as we're gonna get.

OK. Sounds good enough.

I also tested this PR with the uosc UI in my setup.

Thanks for resolving this long-standing feature request.

@trueNAHO trueNAHO merged commit 6c42dc3 into nix-community:master Mar 10, 2025
109 checks passed
brckd pushed a commit to brckd/stylix that referenced this pull request Mar 11, 2025
Closes: nix-community#185
Closes: nix-community#186
Link: nix-community#949

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
brckd pushed a commit to brckd/stylix that referenced this pull request Mar 11, 2025
Closes: nix-community#185
Closes: nix-community#186
Link: nix-community#949

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
brckd pushed a commit to brckd/stylix that referenced this pull request Mar 11, 2025
Closes: nix-community#185
Closes: nix-community#186
Link: nix-community#949

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
brckd pushed a commit to brckd/stylix that referenced this pull request Mar 11, 2025
Closes: nix-community#185
Closes: nix-community#186
Link: nix-community#949

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
@0xda157 0xda157 deleted the init-mpv branch March 14, 2025 19:00
pinarruiz pushed a commit to pinarruiz/stylix that referenced this pull request Mar 26, 2025
Closes: nix-community#185
Closes: nix-community#186
Link: nix-community#949

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
pinarruiz pushed a commit to pinarruiz/stylix that referenced this pull request Mar 26, 2025
Closes: nix-community#185
Closes: nix-community#186
Link: nix-community#949

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Tested-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mpv: add support mpv: add support for uosc

2 participants