DAOS-16661 ci: Ignore detail analysis of PMDK warnings in NLT #457
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grom72
force-pushed
the
grom72/daos-16661
branch
4 times, most recently
from
9c7433f to
f18f152
Compare
grom72
changed the title
grom72
force-pushed
the
grom72/daos-16661
branch
2 times, most recently
from
f39f869 to
b4b67db
Compare
Static analysis of NLT results does not work properly when
a warning source code is out of scope of the project.
An error is reported in such case and the whole stage status
is changed to FAILURE.
```
[NLT results] [-ERROR-] Can't create fingerprints for some files:
[NLT results] [-ERROR-] - 'pmdk/.../src/common/set.c' file not found
...
[NLT results] Failing build because analysis result contains errors
```
To prevent this problem, all PMDK-related messages are filtered out.
NLT results Warnings section will include warnings but will not
provide any detail information about location of this warning
in the source code.
Based on existing format of nlt-errors.json file the most easy way
to filtered all PMDK messages is to use the predefined "pmdk/" preffix
in the fileName:
```
...
{
"fileName": "pmdk/src/../src/common/set.c",
"type": "warning in strict mode",
"lineStart": 2796,
"description": "warning in strict mode",
"message": "util_replica_check() Possible silent data corruption. The unsafe shutdown detection (SDS) is not supported in the pool: /mnt/daos_0/e5737f5f-fa54-45d6-b081-9b2769921610/vos-1\nwarning in strict mode",
"severity": "NORMAL"
},
...
```
vos logging system should ensure that the file name of each PMDK
related message starts with "pmdk/" prefix.
The implementation of the solution is provided in
daos-stack/daos#14923 PR
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
grom72
force-pushed
the
grom72/daos-16661
branch
from
b4b67db to
4adcbc5
Compare
daltonbohning
approved these changes
Mar 3, 2025
This change only may affect NLT and Fault Injection tests No need to execute HW and VM Functional Tests Skip-build-el9-rpm: true Skip-build-leap15-rpm: true Skip-build-ubuntu20-rpm: true Skip-build-leap15-icc: true Skip-unit-test: true Skip-unit-test-memcheck: true Skip-bullseye: true Skip-fault-injection-test: false Skip-func-test-vm-all: true Skip-func-test-hw: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Contributor
Author
|
NLT and Fault Injection Tests passed on |
Merged
20 tasks
janekmi
approved these changes
Mar 4, 2025
This change only may affect NLT and Fault Injection tests No need to execute HW and VM Functional Tests Skip-build-el9-rpm: true Skip-build-leap15-rpm: true Skip-build-ubuntu20-rpm: true Skip-build-leap15-icc: true Skip-unit-test: true Skip-unit-test-memcheck: true Skip-bullseye: true Skip-fault-injection-test: false Skip-func-test-vm-all: true Skip-func-test-hw: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
JohnMalmberg
approved these changes
Mar 4, 2025
Contributor
Author
|
@daltonbohning can we land with this PR not waiting for all upstream validation to be completed? |
Contributor
|
Woops, too late. It actually finished now :) |
grom72
added a commit
to daos-stack/daos
that referenced
this pull request
Mar 6, 2025
daos-stack/pipeline-lib#457 landed on master. This change only may affect NLT and Fault Injection tests No need to execute HW and VM Functional Tests Skip-unit-test: true Skip-unit-test-memcheck: true Skip-bullseye: true Skip-fault-injection-test: false Skip-func-test-vm-all: true Skip-func-test-hw: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NLT results analysis reports an error when it can not get source code of the reported warning.
PMDK reports warnings/errors via VOS logging system but the source code is not available.
Static analysis of NLT results does not work properly when
a warning source code is out of scope of the project.
An error is reported in such case and the whole stage status
is changed to FAILURE.
To prevent this problem, all PMDK-related messages are filtered out.
NLT results Warnings section will include warnings but will not
provide any detail information about location of this warning
in the source code.
Based on existing format of nlt-errors.json file the most easy way
to filtered all PMDK messages is to use the predefined "pmdk/" preffix
in the fileName:
The VOS logging system should ensure that the filename of each PMDK-related message starts with a "pmdk/" prefix.
The implementation of the solution is provided in daos-stack/daos#14923 PR