SRE-3441: Replace Valgrind with recordIssues #483
+71
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some log noise from the Jenkins log. The valgrind plugin is no longer being maintained and does not work correctly. Its desgnated replacement is recordIssues The bulidDaosJob method must only use parameters that exist for the target build. Jenkinsfile: Fix some undeclared variables. vars/buildDaosJob.groovy: Fix to only set parameters tnat exist for that DAOS job. Move build parameter list to creation setupDownStream(). vars/setupDownstreamTesting.groovy: Return list of build parameters that are known to the target branch. vars/valgrindReportPublish.groovy: Use recordIssues method which replaces the PublishValgrind method. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
JohnMalmberg
requested review from
daltonbohning,
frostedcmos,
grom72,
jzarzycki,
kjacque,
phender,
ryon-jensen and
sylviachanoiyee
Collaborator
Author
|
I have not been able to get a clean run of this PR and it does not look like it is going to happen. This PR gets valgrind reporting working again, and eliminates a lot of noise from the Jenkins log. |
daltonbohning
approved these changes
Nov 20, 2025
Contributor
daltonbohning
left a comment
daltonbohning
left a comment
There was a problem hiding this comment.
LGTM but I admit I don't review the valgrind results often
frostedcmos
approved these changes
Nov 20, 2025
kjacque
reviewed
Nov 21, 2025
kjacque
left a comment
kjacque
left a comment
There was a problem hiding this comment.
Looks reasonable to me, though I'm less familiar with groovy. I leave it to folks more familiar to provide the approvals.
Comment on lines
+20
to
+25
| //if (env.DAOS_VALGRIND_DISABLED != null) { | ||
| // Valgrind plugin is not being maintained and is generating log noise | ||
| // This is to allow testing with it disabled or missing. | ||
| println 'Valgrind publishing disabled via DAOS_VALGRIND_DISABLED' | ||
| return | ||
| } | ||
| // println 'Valgrind publishing disabled via DAOS_VALGRIND_DISABLED' | ||
| // return | ||
| //} |
There was a problem hiding this comment.
Does this commented out section need to be removed before landing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some log noise from the Jenkins log.
The valgrind plugin is no longer being maintained and does not work
correctly. Its desgnated replacement is recordIssues
The bulidDaosJob method must only use parameters that exist for the target build.
Jenkinsfile:
Fix some undeclared variables.
vars/buildDaosJob.groovy:
Fix to only set parameters tnat exist for that DAOS job.
Move build parameter list to creation setupDownStream().
vars/setupDownstreamTesting.groovy:
Return list of build parameters that are known to the target branch.
vars/valgrindReportPublish.groovy:
Use recordIssues method which replaces the PublishValgrind method.