Skip to content

Conversation

@roienatan
Copy link
Contributor

@roienatan roienatan commented Feb 24, 2021

resolves: #17

NOTE: Since this PR involves critical code changes it must be tested properly before being merged to dev. It's set to draft since the review app still not working for the monorepo.

@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-better-connect--5hzbmz February 24, 2021 14:01 Inactive
@roienatan roienatan had a problem deploying to alchemy-better-connect--l72gth February 24, 2021 15:11 Failure
@jellegerbrandy jellegerbrandy had a problem deploying to alchemy-better-connect--l72gth February 25, 2021 09:28 Failure
@jellegerbrandy jellegerbrandy had a problem deploying to alchemy-better-connect--l72gth February 25, 2021 09:32 Failure
@jellegerbrandy jellegerbrandy had a problem deploying to alchemy-better-connect--l72gth February 25, 2021 11:49 Failure
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-better-connect--l72gth February 25, 2021 11:50 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-better-connect--jqivjb February 25, 2021 12:01 Inactive
@EzraWeller
Copy link

A couple small things initially:

  1. The redemptions notifications box seems not to adjust to 3+-digit numbers.
  2. The hover-highlighting on the account box should be centered with regard to the account name/address and picture
  3. The account info box that appears on mouseover has a small triangle arrow pointing up to the account. This arrow should probably be centered on the account picture, rather than off to the side on its own.

Lmk if any of those don't make sense. This was the best screenshot I could get with the highlighting, sorry:

IMG-2341 (1)

@EzraWeller
Copy link

Apart from the above, it seems to be working great! Haven't found anything broken yet.

@roienatan roienatan marked this pull request as ready for review March 10, 2021 15:21
@roienatan roienatan temporarily deployed to alchemy-better-connect--ka7svj March 10, 2021 15:22 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-better-connect--erhwus March 10, 2021 15:22 Inactive
@roienatan
Copy link
Contributor Author

A couple small things initially:

  1. The redemptions notifications box seems not to adjust to 3+-digit numbers.
  2. The hover-highlighting on the account box should be centered with regard to the account name/address and picture
  3. The account info box that appears on mouseover has a small triangle arrow pointing up to the account. This arrow should probably be centered on the account picture, rather than off to the side on its own.

Lmk if any of those don't make sense. This was the best screenshot I could get with the highlighting, sorry:

IMG-2341 (1)

Thanks for the comments! They are now fixed especially the digits red box is now dynamic to fit any number.

@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-better-connect--a1nhhm March 10, 2021 15:30 Inactive
@roienatan roienatan temporarily deployed to alchemy-better-connect--a1nhhm March 10, 2021 18:20 Inactive
@roienatan roienatan temporarily deployed to alchemy-better-connect--a1nhhm March 10, 2021 18:56 Inactive
@jellegerbrandy jellegerbrandy merged commit c6e4b3c into dev Mar 11, 2021
@jellegerbrandy jellegerbrandy deleted the better-connect-flow branch March 11, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the login flow to match current standards

4 participants