Make sure proposer name doesn't overlap avatar on proposal history rows #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
why https://alchemy-1551-history-ro-rffoae.herokuapp.com/ does not SHOW_ALL_DAOS as other review app are ? @tibetsprague |
Contributor
Author
|
@orenyodfat i dont know, but why does that effect this review? |
dkent600
approved these changes
Apr 21, 2020
Contributor
because review app does not work as expected .even though it rebased on dev |
Contributor
Author
|
@orenyodfat slug size is too big, thats why |
orenyodfat
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1551
This took much longer to figure out than it looks :)