Skip to content

Remove lockingId from Locking4Reputation.redeem and the Redeem event #549

@dkent600

Description

@dkent600

Locking4Reputation.redeem takes _lockingId for an argument but only uses it for the Redeem event that is emitted. However, a lockingId is completely irrelevant to the redemption, as redeem pays out the entire reputation and score for all locks that the beneficiary has created.

The presence of the lockingId, and the code comment about it, imply that the redemption is only paid for the amount locked. If this is true, then the current behavior of redeem is wrong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions