Skip to content

Should not be able to bid to the wrong auction #594

@dkent600

Description

@dkent600

STEPS

  1. An application informs the user that a certain auction is in progress.
  2. The user places a bid, expecting it to be placed on this auction
  3. Before execution reaches the Auction4Reputation contract, the blockchain time advances such that the auction number also advances. (Easy to happen if the user delays responding to MM prompts)

RESULT

The bid is not placed on the auction that the user intended. User is surprised and disappointed.

NOTES

There is no way to completely avoid the possibility of voting on the wrong auction unless we change the contract's bid method method to take an additional parameter auctionId which would be the id of the auction in which we intend to bid. The contract bid method would revert if the current auctionId is != to the one we intend to bid in.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions