add forwarder scheme #558
Merged
add forwarder scheme #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leviadam
reviewed
Oct 16, 2018
| * @param _avatar the avatar of the dao to forward the call to | ||
| * @param _expirationTime the expirationTime to forwardCall | ||
| */ | ||
| function initialize(Avatar _avatar, uint _expirationTime) external onlyOwner { |
Contributor
There was a problem hiding this comment.
Here there is basically no "time bomb" as the owner can change it.
leviadam
reviewed
Oct 16, 2018
|
|
||
| contract Forwarder is Ownable { | ||
|
|
||
| Avatar public avatar; |
Contributor
There was a problem hiding this comment.
Why Avatar?
Why not make generic and initialize some address.
Contributor
Author
There was a problem hiding this comment.
the avatar is needed to call for unregisterSelf .
we can add another address to make it more generic though I am not sure it is needed.
leviadam
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scheme behave like a "buffer" between 2 daos.