return reputation rewarded from Redeem function #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
suggested changes
Dec 1, 2018
Contributor
orenyodfat
left a comment
orenyodfat
left a comment
There was a problem hiding this comment.
Please add tests.
Let’s keep the version bump to another pr .
orenyodfat
reviewed
Dec 2, 2018
| * @return uint reputation rewarded | ||
| */ | ||
| function redeem(address _beneficiary, uint _auctionId) public returns(bool) { | ||
| function redeem(address _beneficiary, uint _auctionId) public returns(uint) { |
Contributor
There was a problem hiding this comment.
function redeem(address _beneficiary, uint _auctionId) public returns(uint reputation)
remove reputation declaration inside function
orenyodfat
reviewed
Dec 2, 2018
| * @return uint reputation rewarded | ||
| */ | ||
| function redeem(address _beneficiary) public returns(bool) { | ||
| function redeem(address _beneficiary) public returns(uint) { |
Contributor
There was a problem hiding this comment.
function redeem(address _beneficiary) public returns(uint reputation)
and remove reputation declaration inside the function.
orenyodfat
approved these changes
Dec 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dutchx app wants to display to the user how much reputation the user will be rewarded. This PR change greatly facilitates obtaining this value after the locking period has ended and before the rep has been redeemed, and it keeps within the contract the logic for computing reputation.
(The amount of reputation rewarded after redeeming will have to come from the Redeem events.)