Skip to content

FixReputationAllocation - prevent redeem twice for the same beneficiary . #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orenyodfat merged 6 commits into from
Dec 23, 2018
Merged

FixReputationAllocation - prevent redeem twice for the same beneficiary . #571

orenyodfat merged 6 commits into from
Dec 23, 2018

Conversation

@orenyodfat
Copy link
Contributor

@orenyodfat orenyodfat commented Dec 22, 2018 •
edited
Loading

  • FixReputationAllocation - prevent redeem twice for the same beneficiary
  • use safeMath addition in locking4rep
  • Auction4Rep :
    • update initialise function to prevent potential rounding issues.
    • require auction time to be greater than block interval .

@orenyodfat orenyodfat requested a review from leviadam December 22, 2018 15:10
@orenyodfat orenyodfat merged commit cb6df66 into master Dec 23, 2018
@orenyodfat orenyodfat deleted the fix_fix_rep_allocation branch December 23, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dkent600 dkent600 dkent600 approved these changes

@leviadam leviadam leviadam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@orenyodfat @dkent600 @leviadam