Use string as proposal's description hash (for ipfs) #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
changed the title
jellegerbrandy
approved these changes
Jan 7, 2019
Contributor
jellegerbrandy
left a comment
jellegerbrandy
left a comment
There was a problem hiding this comment.
See nothing wrong but perhaps it would be better to use a consistent naming for more clarity: we now use descriptionHash almost everywhere, but also contributionDescription and contributionDescriptionHash Perhaps replace those last two?
leviadam
approved these changes
Jan 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #577
fix #576